Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

getFile is inconsistent #287

Closed
g105b opened this issue Apr 19, 2023 · 0 comments · Fixed by #298
Closed

getFile is inconsistent #287

g105b opened this issue Apr 19, 2023 · 0 comments · Fixed by #298
Assignees
@g105b

Comments

@g105b
Copy link
Member

g105b commented Apr 19, 2023

All other getters return a nullable type, depending on whether the field is present in the input.

getFile throws an exception if there isn't a file.

Make it return null instead, so it's consistent.
@g105b g105b self-assigned this Apr 25, 2024
g105b added a commit that referenced this issue Apr 25, 2024
@g105b
feature: make getFile consistently nullable
d8d33ff 
closes #287
@g105b g105b linked a pull request Apr 25, 2024 that will close this issue
Make getFile consistent with other functions #298
Merged
g105b added a commit that referenced this issue Apr 25, 2024
@g105b
feature: make getFile consistently nullable
be37321 
closes #287
g105b added a commit that referenced this issue Apr 25, 2024
@g105b
Make getFile consistent with other functions (#298)
fea0d65 
* feature: make getFile consistently nullable
closes #287

* build: php 8.1 compatibility

* build: cache php version

* build: fix dependency versions

* ci: use phpunit composer version

* build: php 8.1 compatibility

* ci: upgrade steps

* ci: name build artifact

* ci: hard code version

* test: update phpdoc

* ci: use v4 upload/download artifact

* ci: tag coverage data with sha

* ci: tag coverage run number

* ci: tag coverage matrix build

* ci: typo

* ci: upgrade coverage version

* ci: add php version to coverage information

* ci: add codecov token

* feature: make getFile consistently nullable
closes #287
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@g105b g105b

Labels
None yet
Projects
Overview
Status: April 2024
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make getFile consistent with other functions PhpGt/Input
1 participant
@g105b