Workflow integration #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
akuker
commented
Aug 28, 2020
akuker
commented
- Updated makefile to create multiple "connection type" builds at the same time
- Updated github workflow to build the fullspec and standard versions of rascsi and archive the files
- Updated github workflow to work for all branches
- Updated makefile to only re-build changed files and to generate/use the headers when checking for changes
added 6 commits
August 28, 2020 10:19
…ency listings to check for modified header files
… and standard versions of the app
sfiera
approved these changes
Aug 30, 2020
| OBJ_RASDUMP := $(SRC_RASDUMP:%.cpp=$(OBJDIR)/%.o) | ||
| OBJ_SASIDUMP := $(SRC_SASIDUMP:%.cpp=$(OBJDIR)/%.o) | ||
| OBJ_SCSIMON := $(SRC_SCSIMON:%.cpp=$(OBJDIR)/%.o) | ||
| OBJ_RASCSI := $(addprefix $(OBJDIR)/,$(notdir $(SRC_RASCSI:%.cpp=%.o))) |
There was a problem hiding this comment.
If you started the compilation and linker rules with @mkdir -p $(dir $@), you could keep the directories in the path and revert the path manipulation you added. (also remove the dirs from prereqs)
There was a problem hiding this comment.
I'm not a fan of having shell commands inline in the makefile. I prefer to use the target/prerequisites functionality of make. Are you OK with leaving this the way it is?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.