Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: kakao-login 구현 완료 #17

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

feat: kakao-login 구현 완료 #17

wants to merge 1 commit into from

Conversation

GaHee99
Copy link
Contributor

@GaHee99 GaHee99 commented Jun 26, 2023

🖼️ 작업한 내용

  • Kakao-login 구현 완료했습니다!
  • 라우터 : [/auth/kakao/signin]

📸 PR Point

  • authServiceImpl에서 refreshToken, accessToken 업데이트 하는부분 updateAccessTokenAndRefreshToken로 메서드 추출했습니다!
  • 자체로그인의 createUser, loginUser에도 반영하면 좋을 것 같아요!
  • responeDto를 자체로그인 Dto랑 똑같은 dto를 사용했는데, 그거에 대해서 어떻게 생각하시는지도 궁굼합니다!
    (소셜로그인, 자체로그인 responseDTO 스펙이 똑같아요!)
  • 픽미 서버 살앙훼

✍️ 관련 이슈

wlwpfh
wlwpfh approved these changes Jul 3, 2023
View reviewed changes
Copy link
Contributor

@wlwpfh wlwpfh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

깔끔해요! ! 수고하셨습니다! ! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wlwpfh wlwpfh wlwpfh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

소셜로그인
2 participants
@GaHee99 @wlwpfh