Add irb2600 185 #53
Add irb2600 185 #53
Conversation
There was a problem hiding this comment.
Thanks a lot for this contribution! Left some minor comments as feedback.
One big request is to simplify the visual meshes for the two new robots. Some of the files are several megabytes which would bloat this repository. Really appreciate the effort to simplify the collision meshes!!
abb_bringup/package.xml
Outdated
| @@ -16,6 +16,8 @@ | |||
| <test_depend>rclcpp</test_depend> | |||
| <test_depend>abb_irb1200_5_90_moveit_config</test_depend> | |||
| <test_depend>abb_irb1200_support</test_depend> | |||
| <test_depend>abb_irb2600_12_185_moveit_config</test_depend> | |||
There was a problem hiding this comment.
I don't see any changes being made to abb_bringup/test_command_topics.py so we don't have to add these pkgs as dependencies.
| SRDF: | ||
| relative_path: config/abb_irb2600_12_185.srdf | ||
| CONFIG: | ||
| author_name: Andrew Short |
There was a problem hiding this comment.
Just to check, are you the author listed here?
| os.path.join( | ||
| robot_description_path, | ||
| "urdf", | ||
| "irb2600_12_185.xacro", |
There was a problem hiding this comment.
Since you have urdfs for irb2600_12_185 and the irb2600_12_165 variants, it would be good to add a new launch configuration that stores the variant name (default can be irb2600_12_185) so that the robot to be visualised can be set via launch arg.
| robot_description = {"robot_description": robot_description_config.toxml()} | ||
|
|
||
| robot_state_publisher_node = Node( | ||
| package="robot_state_publisher", |
There was a problem hiding this comment.
Add <exec_depend>robot_state_publisher</exec_depend> to package.xml
| ) | ||
|
|
||
| joint_state_sliders = Node( | ||
| package="joint_state_publisher_gui", |
There was a problem hiding this comment.
Add <exec_depend>joint_state_publisher_gui</exec_depend> to package.xml
| <?xml version="1.0" encoding="UTF-8"?> | ||
| <robot name="abb_irb2600_12_165" xmlns:xacro="http://ros.org/wiki/xacro"> | ||
| <xacro:include filename="$(find abb_irb2600_support)/urdf/irb2600_12_165_macro.xacro"/> | ||
| <xacro:abb_irb2600_12_165 prefix=""/> |
There was a problem hiding this comment.
Missing ros2_control tags like you have in irb2600_12_185.xacro?
| </hardware> | ||
| <joint name="${prefix}joint_1"> | ||
| <command_interface name="position"> | ||
| <param name="min">{-2*pi}</param> |
There was a problem hiding this comment.
None of the joint command interface limits here match the limits specified in the urdf. Kindly update these values.
| <parent link="${prefix}link_1"/> | ||
| <child link="${prefix}link_2"/> | ||
| <!-- See note 2 in package.xml about effort limits and dynamics values --> | ||
| <limit lower="-2.705" upper="1.658" effort="0" velocity="3.054"/> |
There was a problem hiding this comment.
Same comments regarding joint limits as the irb2600_12_185 file above.
| joint_limits: | ||
| joint_1: | ||
| has_velocity_limits: true | ||
| max_velocity: 5.027 |
There was a problem hiding this comment.
The max_velocity values in this file do not correspond to the limits set in the urdf. The values here can be lower than max limits specified in the urdf but not higher.
| <buildtool_depend>ament_cmake</buildtool_depend> | ||
|
|
||
| <exec_depend>abb_irb2600_support</exec_depend> | ||
| <exec_depend>joint_state_publisher</exec_depend> |
There was a problem hiding this comment.
The dependencies other than abb_irb2600_support should theoretically be moved into the package.xml of abb_irb2600_support as they are required to launch view_robot.launch.py.
|
@Yadunund Thank you for your comments, I think I solved all of them. Can you maybe check again? I also reduce the size of the meshes by half. |
No description provided.