Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(apps/prod/publisher): fix publisher config #1290

Merged
merged 1 commit into from
Oct 16, 2024
Merged

Conversation

wuhuizuo
Copy link
Collaborator

Signed-off-by: wuhuizuo [email protected]

@ti-chi-bot ti-chi-bot bot requested a review from purelind October 16, 2024 12:04
@ti-chi-bot ti-chi-bot bot added area/apps env/prod will deploy on the main product cluster labels Oct 16, 2024
Copy link
Contributor

ti-chi-bot bot commented Oct 16, 2024

I have already done a preliminary review for you, and I hope to help you do a better job.

Based on the pull request, the key changes are:

  • The config files have been moved from args to servers and config in both release-prod-mirror.yaml and release-staging-mirror.yaml.
  • The config volume for both files has been removed.

Some potential problems that I see are:

  • There is no explanation as to why the changes were made. It would be helpful to provide some context for the changes to help reviewers understand the reasoning behind them.
  • There is no indication that these changes were tested. It would be helpful to include a description of the testing that was done to ensure that these changes are functional.
  • The config volume has been removed, but it is not clear how the configuration files are being mounted without it. It would be good to clarify this in the pull request description.

Some suggestions for fixing these potential problems are:

  • Add a brief explanation to the pull request description to clarify why these changes were made.
  • Include a description of the testing that was done to confirm that the changes are functional.
  • Clarify how the configuration files are being mounted without the config volume.

@ti-chi-bot ti-chi-bot bot added the size/M label Oct 16, 2024
Copy link
Collaborator Author

@wuhuizuo wuhuizuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Copy link
Contributor

ti-chi-bot bot commented Oct 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wuhuizuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Oct 16, 2024
@ti-chi-bot ti-chi-bot bot merged commit 852c06c into main Oct 16, 2024
4 checks passed
@ti-chi-bot ti-chi-bot bot deleted the fix/publisher-gitops branch October 16, 2024 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/apps env/prod will deploy on the main product cluster size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant