Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistent opensubdiv3 headers #3

Closed
PeterShinners opened this issue Jul 27, 2016 · 6 comments
Closed

Inconsistent opensubdiv3 headers #3

PeterShinners opened this issue Jul 27, 2016 · 6 comments

Comments

@PeterShinners
Copy link
Contributor

PeterShinners commented Jul 27, 2016 •
edited
Loading

The build system in FindOpenSubdiv.cmake looks for ${OPENSUBDIV_INCLUDE_DIR}/opensubdiv/version.h, but the source code in pxOsd is referencing #include <opensubdiv3/far/topologyRefiner.h>. I'm not sure if opensubdiv or opensubdiv3 is the preferred include path, but on my Arch Linux system the opensubdiv package put them under /usr/include/opensubdiv
@waywardmonkeys
Copy link
Contributor

Building and installing the opensubdiv code on Mac OS X also put them in .../opensubdiv

@meshula
Copy link
Member

meshula commented Jul 30, 2016

Similar issue exists for ubuntu.

@TheRealJokerMan
Copy link

And for Windows.

@amooty
Copy link

amooty commented Aug 2, 2016

Filed as internal issue #135155.

@mont29
Copy link

mont29 commented Aug 14, 2016

erf… just saw that one, fwiw fixed this in own fork, and created a pull request

pixar-oss pushed a commit that referenced this issue Aug 17, 2016
@takahito-tejima @pixar-oss
[Hd, PxOsd] replace opensubdiv3/ include path with opensubdiv/
259a55f 
"opensubdiv3/" include path had been used to support both 2.x and 3.x
at the same time so that we can compare the results between those versions.
now that opensubdiv 2.x support in hydra has been removed,
we no longer need to distinguish the version by include path.

closes #3
#3

(Internal change: 1643830)
@sunyab
Copy link
Contributor

sunyab commented Aug 17, 2016

This should be fixed with 259a55f. Closing!

@sunyab sunyab closed this as completed Aug 17, 2016
@aloysbaillet aloysbaillet mentioned this issue Oct 18, 2016
Open
@spiffmon spiffmon mentioned this issue Mar 24, 2017
Closed
@alexwheezy alexwheezy mentioned this issue Jun 19, 2017
Closed
@asluk asluk mentioned this issue May 8, 2019
Closed
kaischroeder referenced this issue in autodesk-forks/USD Feb 2, 2022
@kaischroeder
Merge pull request #3 from frericp/hdEmscripten_cleanup
6d10683 
cleanup and minor fixes
This was referenced Feb 9, 2022
Open
Closed
Closed
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@waywardmonkeys @meshula @PeterShinners @mont29 @TheRealJokerMan @sunyab @amooty