Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cmake Alembic detection script needs to recognize newer Alembic builds. #70

Closed
meshula opened this issue Sep 30, 2016 · 4 comments
Closed

Comments

@meshula
Copy link
Member

meshula commented Sep 30, 2016

On Windows, Alembic no longer builds to many small libraries, instead only a single DLL and lib are generated.

That means that the detection should look something like this:

    find_library(ALEMBIC_LIBRARY
                 NAMES Alembic
                 PATHS ${LIBRARY_PATHS})

    set(ALEMBIC_LIBRARIES ${ALEMBIC_LIBRARY})

    get_filename_component(ALEMBIC_LIBRARY_DIR ${ALEMBIC_LIBRARY} PATH)

A possible solution would be to add a detection phase in the Cmake script, along the lines of

if (NOT ALEMBIC_ABC_LIBRARY_FOUND)
   message("Historic Alembic not detected, looking for modern Alembic")
   .... then do something like what I listed above.
endif()

@jtran56
Copy link

jtran56 commented Sep 30, 2016

Filed as internal issue #138129.

@ghost
Copy link

ghost commented Sep 30, 2016

Nick,

I believe this only applies to the latest version. But agreed, it would be nice if we are to support versions > 1.5.2.

@asluk
Copy link
Collaborator

asluk commented Oct 1, 2016

Yep, I think this affects versions >= 1.6.0 , per alembic/alembic@834eca6

I can take a look at this.

@sunyab
Copy link
Contributor

sunyab commented Dec 10, 2016

Commit has been merged into release v0.7.2, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants