Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shouldn't detect X11 on macOS #72

Closed
meshula opened this issue Sep 30, 2016 · 1 comment
Closed

Shouldn't detect X11 on macOS #72

meshula opened this issue Sep 30, 2016 · 1 comment
Assignees

Comments

@meshula
Copy link
Member

meshula commented Sep 30, 2016

The bit of code below will mess up macOS users with X11 installed, in the sense that an X11 dependency will be baked into USD. When a developer builds, say a Maya plugin for USD, and then attempts to distribute it to an artist, the artist will be doomed to install X11. Since the graphics functions on macOS don't use X11, X11 should not be searched for at all on macOS. Ditto for Windows of course.

if (PXR_BUILD_IMAGING)
    # --OpenImageIO
    find_package(OpenImageIO REQUIRED)
    # --OpenGL
    find_package(OpenGL REQUIRED)
    find_package(GLEW REQUIRED)
    # --Opensubdiv
    find_package(OpenSubdiv 3 REQUIRED)
    # --Ptex
    find_package(PTex REQUIRED)
    # --X11
    find_package(X11)
    # --Qt
    find_package(Qt4)
    if (QT4_FOUND)
        find_package(PySide REQUIRED)
    endif()
endif()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants