Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support time-sampled computed primvars #1455

Merged

Commits on Feb 10, 2021

  1. Add methods for requesting time samples of an ExtComputation input,

    similar to SamplePrimvar()
    cameronwhite committed Feb 10, 2021
    Configuration menu
    Copy the full SHA
    2ca8b6d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    9c94692 View commit details
    Browse the repository at this point in the history
  3. Add method to HdExtComputationUtils for evaluating time samples of

    computed primvars.
    
    Also added a VtValue specialization of HdResampleNeighbors(), for
    resampling an HdTimeSampleArray of VtValue's.
    cameronwhite committed Feb 10, 2021
    Configuration menu
    Copy the full SHA
    2147ee6 View commit details
    Browse the repository at this point in the history

Commits on Feb 16, 2021

  1. Remove an unnecessary warning.

    If the value type can't be interpolated, just hold the previous sample's
    value rather than producing a runtime warning.
    cameronwhite committed Feb 16, 2021
    Configuration menu
    Copy the full SHA
    a75fb50 View commit details
    Browse the repository at this point in the history
  2. Add a basic unit test for SampleComputedPrimvarValues().

    This uses a simple computation to test the handling of time samples and
    interpolating input samples.
    cameronwhite committed Feb 16, 2021
    Configuration menu
    Copy the full SHA
    6daf75e View commit details
    Browse the repository at this point in the history

Commits on Feb 24, 2021

  1. Improvements and refactoring for the VtValue version of HdResampleNei…

    …ghbors().
    
    - Remove the USD dependency and just directly specify the types we
      expect to interpolate.
    - Replace the BOOST_PP_SEQ_FOR_EACH usage with variadic templates.
    - Fix some inconsistent code formatting.
    cameronwhite committed Feb 24, 2021
    Configuration menu
    Copy the full SHA
    9970cd0 View commit details
    Browse the repository at this point in the history

Commits on Mar 3, 2021

  1. Add an HdTimeSampleArray variant of SampleExtComputationInput().

    This is similar to related methods such as SamplePrimvar().
    cameronwhite committed Mar 3, 2021
    Configuration menu
    Copy the full SHA
    5ffc6fd View commit details
    Browse the repository at this point in the history

Commits on Mar 5, 2021

  1. Allow controlling the static capacity of the SampledValueStore arrays.

    This removes the hardcoded static capacity of 4, and templates
    SampledValueStore to use the static capacity specified by the client
    code.
    
    Additionally, the internal _ExecuteSampledComputations() method is now
    templated so that the static capacity of its value store arrays are also
    controlled by the client.
    
    Factored out some parts of the _ExecuteSampledComputations()
    implementation that do not rely on the template parameter. This limits
    the amount of code moved into the header (in particular, this also hides
    the usage of internal classes such as Hd_ExtComputationContextInternal).
    cameronwhite committed Mar 5, 2021
    Configuration menu
    Copy the full SHA
    15ae4db View commit details
    Browse the repository at this point in the history