APPLE: Fix for building boost 1.78 on macOS universal #2144
Conversation
|
Filed as internal issue #USD-7845 |
build_scripts/build_usd.py
Outdated
| # If Python2 is also installed in the system then it is sometimes | ||
| # found first, so we force the bootstrap to Python3 | ||
| bootstrapCmd += " --with-python-version=3" | ||
|
|
There was a problem hiding this comment.
It seems like this ought to only be needed if context.buildPython is enabled. I think it could also use the information returned by GetPythonInfo to specify the full version, like:
if context.buildPython:
pythonInfo = GetPythonInfo(context)
bootstrapCmd += " --with-python-version={ver}".format(ver=pythonInfo[3])
In theory this seems like this should be independent of macOS but I'm OK with leaving it in this block for now and just adding a comment saying something to that effect.
There was a problem hiding this comment.
After testing this on the latest public release of macOS Ventura it seems that the --with-python-version=3 option isn't necessary. It only causes a problem for our internal builds. So I think I can remove it. The other change, to remove the combined option is needed with 1.78 to build universal binaries.
creijon
force-pushed
the
jon/dev/fix_boost_178
branch
from
25aaf79
to
5ea7a7a
Compare
|
Sorry, I force-pushed this by accident. Will re-open under a new PR. |
|
Re-created as #2150 |
Description of Change(s)
With the latest dev push, boost has been updated to 1.78.
With this version b2 no longer requires the
architecture=combinedoption for universal builds and throws an error if it is defined.Fixes Issue(s)