Disable shadows on the "simple" headlight #2373
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ight. Because it is a distant light, and not an actual "headlight" co-located with the camera, interior scenes will be entirely in shadow. Submitting this on behalf of @crydalch spawned from this discussion on usd-interest: https://groups.google.com/g/usd-interest/c/ShnbqGtpi_0
|
We gave some consideration to extending GlfSimpleLight to have a flag indicating whether shadows should be turned on or off (for either dome or headlight mode), but opted against it since we felt this simpler change would satisfy most use cases without adding user/UI complexity. |
|
Filed as internal issue #USD-8198 |
2 tasks
|
Should this PR now be closed? There is some confusion in the commit referenced above (28cefab), where the commit contents are from this PR, but the comment is from a different PR. But if the change here has been merged (and it looks like it has), this should be closed? |
|
Yes, thanks for adding the commit, for posterity, @marktucker |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using a "simple" headlight, turn off shadows generated by this light.
Because it is a distant light, and not an actual "headlight" co-located with the camera, interior scenes will be entirely in shadow. Submitting this on behalf of @crydalch spawned from this discussion on usd-interest: https://groups.google.com/g/usd-interest/c/ShnbqGtpi_0
Description of Change(s)
Changed the code in the TaskController that translates a GlfSimpleLight into explicit values stored in the task controller's custom scene delegate so that simple dome lights have shadows enabled, but simple distant light have shadows disabled.