Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace boost::iterator_facade with explicit implementation for SdfChildrenView's internal iterator #2390

Merged

Conversation

nvmkuruc
Copy link
Collaborator

@nvmkuruc nvmkuruc commented Apr 19, 2023

Description of Change(s)

Fixes Issue(s)

  • I have verified that all unit tests pass with the proposed changes
  • I have submitted a signed Contributor License Agreement

@sunyab
Copy link
Contributor

sunyab commented Apr 20, 2023

Filed as internal issue #USD-8253


_InnerIterator() :
_owner(NULL), _pos(0) { }
_InnerIterator() = default;
_InnerIterator(const This* owner, const size_t& pos) :
_owner(owner), _pos(pos) { }

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm pretty sure you're going to need operator-> here too. This iterator is the type for SdfChildrenView::const_iterator (after all the template expansion) so it's highly likely that we have Presto code that dereferences via ->

@pixar-oss pixar-oss merged commit cafdede into PixarAnimationStudios:dev Aug 4, 2023
36 checks passed
@nvmkuruc nvmkuruc deleted the sdfchildrenviewfacade branch December 29, 2023 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants