Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide enough information to allow matrix33 default values #2545

Conversation

francis-wangfr
Copy link
Contributor

Description of Change(s)

Remembers default values of matrix33 inputs in Sdr.

This follows the fix done for Boolean inputs done in #1789

Fixes Issue(s)

  • N/A
  • I have verified that all unit tests pass with the proposed changes
  • I have submitted a signed Contributor License Agreement

Description of Change(s)

Remembers default values of matrix33 inputs in Sdr.

This follows the fix done for Boolean inputs done in PixarAnimationStudios#1789
@francis-wangfr francis-wangfr changed the title USD-47 - Provide enough information to allow matrix33 default values Provide enough information to allow matrix33 default values Jul 19, 2023
@JGamache-autodesk
Copy link
Contributor

Fixes #2523

@jesschimein
Copy link

Filed as internal issue #USD-8513

@spiffmon
Copy link
Member

Thank you, @francis-wangfr ! It looks like you are not currently in the Autodesk CLA - could you please ask Gordon to add you?

@francis-wangfr
Copy link
Contributor Author

Thank you, @francis-wangfr ! It looks like you are not currently in the Autodesk CLA - could you please ask Gordon to add you?

Yes, @spiffmon, thank you for nice reminder, I was just ware of this, it is still working in progress.

@erikaharrison-adsk
Copy link
Contributor

Fyi, a request has gone out to Gordon. I'm happy to vouch for this work as well, or I can close and re-submit this if that's more effective. (I just got back from 2 weeks vacation; Francis was filling in during that time).

@erikaharrison-adsk
Copy link
Contributor

@francis-wangfr or @spiffmon Can you please close this and I'll re-submit it. github is being "too smart" and won't easily let me submit a new PR, and I'm unable to close this.

@pixar-oss pixar-oss closed this Jul 27, 2023
@pixar-oss
Copy link
Member

Closed request at @erikaharrison-adsk's request. Feel free to submit a new PR at your convenience!

@erikaharrison-adsk erikaharrison-adsk deleted the adsk/bugfix/remember-matrix33-default-value branch October 5, 2024 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants