Python janitorial work #26
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These do not change are alter the code in any way, but likely come from fingers of habit from C developers.
A handful of Python files in usdviewq have stray tab indentions. This is technically an error, but Python2 tries to guess at the intention of the code. All tabs are removed.
Several files were importing modules never used. There were also several cases of modules being imported at the top module scope and then again later inside functions.
This is what configures Python to use new style classes. Several of these classes are meant as lightweight placeholders for enumerations, but it still seems consistent to derive everything from object.
In an unlikely warning the incorrect variable was being used to format the message.
The View class derived from QTextEdit was not calling the init method from the base.
When viewing through something that is not a camera, an error message was missing the import for PrintWarning.
pixar-oss
added a commit
that referenced
this pull request
Aug 30, 2016
|
This pull request was merged in 30a04e1. Thanks @PeterShinners! |
This was referenced Feb 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This trivial stream of fixes attempts to do the following:
I've attempted to break the changes into logical commits. None of these really improve the software, but a couple unlikely warning messages will now show up properly.