Fix broken OpenEXR link in README #32
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @asluk, I believe the relative links to the supported platforms section in dev have already been fixed. If you could update the PR to reflect that, I'd appreciate it. |
asluk
changed the title
|
Sure thing Josh; I've updated the PR to only refer to the broken OpenEXR link. Cheers~ |
(Internal change: 1645824) (Internal change: 1646184) (Internal change: 1646387)
This change adds a black fallback texture for the case where a usd-imaged UV texture is missing a valid filepath. Note that ptex fallbacks are not currently implemented. (Internal change: 1645825)
…n at arbitrary start and end times. Implementation details: Upon processing of the PxrUsdIn args, we determine the motion direction. If the motion is backward, when building attributes with motion samples, we flip the sign of sample times before inserting into the attribute builder. (Internal change: 1645902)
px_vp20Utils::setupLightingGL() already does this for lights when rendering in Maya using VP2.0, but that code is bypassed when using VP1.0. (Internal change: 1645964)
…iting out the usdGenSchema Python file. CMake was stripping out semicolons. This caused the resulting python file to have the following string: customCode = _ExtractCustomCode(clsHFilePath, default='}\n\n#endif\n') whereas the original had: customCode = _ExtractCustomCode(clsHFilePath, default='};\n\n#endif\n') This caused usdGenSchema to generate syntactically invalid C++ classes( no closing semicolon) in the case where a user had no custom code and the default string above would be used. Credit to github user murphyeoin for filing the bug and pointing us to the fix. Fixes PixarAnimationStudios#15 (Internal change: 1646239)
instance method from python (see testTfPython for an example). (Internal change: 1646384)
…cate. We evaluate this predicate for every prim index computed during parallel indexing that has a payload and isn't in the cache's include set. If the predicate returns true, then we index with the payload included, and add the payload to the cache's include set as indexing completes. Usd makes use of this to auto-include discovered payloads at stage open time, and to auto-load new payloads if their nearest ancestor's payload was also included. (Internal change: 1646394)
(Internal change: 1646439)
This allows the usdImaging component to build on systems that have Qt4 but not PySide. In such cases, usdview will just not be available. Fixes PixarAnimationStudios#18 (Internal change: 1646492)
(Internal change: 1646517)
(Internal change: 1646966)
(Internal change: 1647544)
… preserve old behavior (Internal change: 1647645)
Fixes incorrect syntax for checking the existence of the pyside-uic binary, which caused the PYSIDE_FOUND flag to not be set properly. Also add a status message indicating if PySide was found at cmake time. (Internal change: 1647848)
(Internal change: 1648091)
Fixes PixarAnimationStudios#21 (Internal change: 1648093)
…iting camera guides such as focus plane. (Internal change: 1650399)
suppress marking collection dirty if the collection is not actually being changed. (Internal change: 1650406)
replacing default function parameter with function overload. (Internal change: 1650472)
takes precedence over setting the thread limit via any of the libWork API calls. (Internal change: 1650475)
Add BlockIndices() and update IsIndexed() to query this. (Internal change: 1650542)
These do not change are alter the code in any way, but likely come from fingers of habit from C developers.
A handful of Python files in usdviewq have stray tab indentions. This is technically an error, but Python2 tries to guess at the intention of the code. All tabs are removed.
Several files were importing modules never used. There were also several cases of modules being imported at the top module scope and then again later inside functions.
This is what configures Python to use new style classes. Several of these classes are meant as lightweight placeholders for enumerations, but it still seems consistent to derive everything from object.
In an unlikely warning the incorrect variable was being used to format the message.
The View class derived from QTextEdit was not calling the init method from the base.
When viewing through something that is not a camera, an error message was missing the import for PrintWarning.
(Internal change: 1650399)
(Internal change: 1650706)
(Internal change: 1650837)
(Internal change: 1650842)
analysis reveals that it's totally valid to not have a spec w/ relocate in every layer (duh) and we should just skip layers without relocating specs here. (Internal change: 1650844)
extends usdview's HUD->GPU stats to show GPU memory allocation. (Internal change: 1650845)
this change is the first iteration of refactoring hd drawtarget API. - make HdDrawTargetRenderPass not a HdTask - remove simpleLightingShader dependency from Hd - remove HdRenderPassState from HdDrawTargetRenderPass - HdxDrawTargetTask manages HdRenderPassState and HdSimpleLightingShader along with HdDrawTargetRenderPass. (Internal change: 1650907)
…spawning parallel work. The parallel work might invoke plugin code that needs the GIL. (Internal change: 1650916)
(Internal change: 1650977)
(Internal change: 1650978)
…ead, which is not okay per python docs. (Internal change: 1650979)
…o avoid redundant permission checks on SetField() calls that redirect to EraseField. (Internal change: 1650986)
(Internal change: 1650989)
(Internal change: 1650990)
(Internal change: 1650991)
|
Didn't mean to close this; had some mayhem in my local repo. Should be resolved now, but if it's easier, I can just remake the change in a fresh branch; it's just correcting the OpenEXR webpage. |
|
nm; I'll remake the change in a fresh branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix link to OpenEXR homepage.