[Usd] Provide a quiet mode for usdGenSchema. #480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is useful to have when integrating usdGenSchema with build systems.
superfunc
force-pushed
the
schemaGenQuietMode
branch
from
9a0c025
to
aaff027
Compare
|
Filed as internal issue #160428. |
pixar-oss
added a commit
that referenced
this pull request
Jul 3, 2019
[Usd] Provide a quiet mode for usdGenSchema. (Internal change: 1985241)
AdamFelt
pushed a commit
to autodesk-forks/USD
that referenced
this pull request
Apr 16, 2024
…parate sharedData from the text draw item. (PixarAnimationStudios#480) ### Description of Change(s) The draw items for underline and overline should use separate sharedData from the text draw item. ### Reason The sharedData contains a map between DrawingCoord index and Buffer range. For example, the constant topology index should map to the constant buffer range. If a primitive has multiple draw items, we need to assign different indices for different draw items. For example, the points topology for the text draw item should be different from the points topology of the underline draw item, so that we can set different point buffer range. Originally, we define different topology index for different draw items in the DrawingCoord enumeration. But there is still problem if instancing is enabled. There will be one instancing index for one instance of a draw item. For example, if there are 5 instances for a text, there will be 5 instancing index. To achieve this, we define the base of instancing index at the end of the DrawingCoord enum, and the index of each instance will be expanded from the base. If there is multiple draw items, their instancing indices should not overlap. As a draw item may have hundreds of instances, it is impossible to guarantee the instancing index is not overlap for different draw items. So the only way is to use separate sharedData for different draw item. If two draw items use separate sharedData, we can use the same index because the buffer range will be set to different sharedData.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change(s)
Pretty non-invasive change to provide a quiet mode to usdGenSchema. This would be really useful to have. While this could be done with whatever script is calling it, it gives users a much simpler interface for doing so at a low cost to us(in terms of code complexity etc).
Fixes Issue(s)