Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

codgenTemplate for multipleApply API schema has hardcoded entries that should be templates #799

Closed
ablev-dwa opened this issue Mar 15, 2019 · 2 comments

Comments

@ablev-dwa
Copy link
Contributor

Description of Issue

When running usdGenSchema to generate code for a multipleApply API schema, I noticed some bugs when trying to build. I think these are just oversights in the template. I'm filing this here because due to some internal changes our ability to make a public PR is delayed for a while 🙄 and this would be an otherwise easy fix - sorry about that.

Here, this is returning UsdCollectionAPI and warning about collections, when it should return an invalid instance of the new schema class and print a more generic warning:
https:/PixarAnimationStudios/USD/blob/master/pxr/usd/lib/usd/codegenTemplates/schemaClass.cpp#L82

These lines refer to UsdTokens, but should probably refer to {{ tokensPrefix }}Tokens:
https:/PixarAnimationStudios/USD/blob/master/pxr/usd/lib/usd/codegenTemplates/schemaClass.cpp#L156
https:/PixarAnimationStudios/USD/blob/master/pxr/usd/lib/usd/codegenTemplates/schemaClass.cpp#L158

Steps to Reproduce

  1. Create a new multipleApply API schema
  2. Run usdGenSchema
  3. Try to compile your new schema - it will fail

System Information (OS, Hardware)

Linux

Package Versions

0.18.9 to 0.19.3

@spiffmon
Copy link
Member

Yikes - we'll try to get that taken care of ASAP, Alan!

@jilliene
Copy link

Filed as internal issue #USD-5163

AdamFelt pushed a commit to autodesk-forks/USD that referenced this issue Apr 16, 2024
…webgpu/fix-case-timeout

Fix test cases timeout that found on Jenkins-based CI/CD pipeline
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants