Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[usdedit] Don't keep a file descriptor open for the temporary usda. #1094

Merged

Conversation

asluk
Copy link
Collaborator

@asluk asluk commented Jan 18, 2020

Description of Change(s)

[usdedit] Don't keep a file descriptor open for the temporary usda.

It is not needed, and prevents usdcat from writing to it in Windows.
Also ensure write permissions when removing the temporary usda,
otherwise usdedit -n will be unable to remove it on Windows.

Fixes Issue(s)

usdedit extras\usd\tutorials\convertingLayerFormats\Sphere.usd
The process cannot access the file because it is being used by another process.
Error: Failed to open file extras\usd\tutorials\convertingLayerFormats\Sphere.usd, exiting.

@jilliene
Copy link

Filed as internal issue #USD-5811

@asluk
Copy link
Collaborator Author

asluk commented Mar 15, 2020

This would be another one that would be nice to get into 20.05, as it gets usdedit working on Windows.

It is not needed, and prevents usdcat from writing to it in Windows.
Also ensure write permissions when removing the temporary usda,
otherwise usdedit -n will be unable to remove it on Windows.
@c64kernal
Copy link
Contributor

Thanks for the fix, @asluk

@pixar-oss pixar-oss merged commit 2d667ab into PixarAnimationStudios:dev Mar 24, 2020
@asluk asluk deleted the fix-usdedit-win branch December 30, 2020 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants