Fix the typo for building USD on Windows. #1120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Visual Studio is a 32 bit application, however certain components (e.g. MSBuild, compilers, etc... ) are 64-bit if available. https://developercommunity.visualstudio.com/content/problem/517541/vs-2019-downloaded-x64-version-installed-x86.html
HamedSabri-adsk
commented
Feb 22, 2020
| @@ -142,7 +142,7 @@ then build and install USD into ```/opt/local/USD```. | |||
| Launch the "Developer Command Prompt" for your version of Visual Studio and | |||
| run the script in the opened shell. Make sure to use the 64-bit (x64) command | |||
| prompt and not the 32-bit (x86) command prompt. (Note if you're trying to | |||
| build with Visual Studio 2017, use the "x86 Native Tools Command Prompt for VS | |||
| build with Visual Studio 2017, use the "x64 Native Tools Command Prompt for VS | |||
| 2017"). | |||
There was a problem hiding this comment.
I think below sentence is still redundant
Note if you're trying to build with Visual Studio 2017, use the "x64 Native Tools Command Prompt for VS
2017")
since prior sentence provides this information.
|
Filed as internal issue #USD-5878 |
|
Thanks for catching this @HamedSabri-adsk! I've merged your PR internally, but I agree that the instructions are a bit redundant so I'll clean that up as a follow-up. |
|
@sunyab Great, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Visual Studio is a 32 bit application, however certain components (e.g. MSBuild, compilers, etc... ) are 64-bit if available.
https://developercommunity.visualstudio.com/content/problem/517541/vs-2019-downloaded-x64-version-installed-x86.html