Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a virtual destructor for PcpDynamicFileFormatInterface #1156

Merged

Conversation

marktucker
Copy link
Contributor

Provide a virtual destructor for PcpDynamicFileFormatInterface to prevent
build errors with some compiler/linker combinations when building plugins
containing subclasses of this class. In particular, gcc compilers with
-Werror=non-virtual-dtor would fail without this.

Description of Change(s)

Add an empty virtual destructor to the abstract PcpDynamicFileFormatInterface base class.

…vent

build errors with some compiler/linker combinations when building plugins
containing subclasses of this class.
@jilliene
Copy link

jilliene commented Apr 8, 2020

Filed as internal issue #USD-5972

@pixar-oss pixar-oss merged commit b19ad16 into PixarAnimationStudios:dev Apr 20, 2020
@marktucker marktucker deleted the dev_dynfileformat_destructor branch July 22, 2020 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants