[HdMtlx] Fix duplicate name error when processing HdNetwork from Houdini #1659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Filed as internal issue #USD-6973 |
bernardkwok
reviewed
Nov 2, 2021
| @@ -277,7 +277,7 @@ _GatherUpstreamNodes( | |||
|
|
|||
| // Initilize the mxNodeGraph if needed | |||
| if (!(*mxNodeGraph)) { | |||
| const std::string & nodeGraphName = hdNodePath.GetParentPath().GetName(); | |||
| std::string nodeGraphName = hdNodePath.GetParentPath().GetName() + "_Graph"; | |||
There was a problem hiding this comment.
As a suggestion here, there is a makeUniqueChildName() method which can be called on mxDoc, and should be more robust than appending "_Graph" -- in case this is also a duplicate.
There was a problem hiding this comment.
Seems like you mean createValidChildName. Yeah we can use it here
pixar-oss
pushed a commit
that referenced
this pull request
Dec 18, 2021
…eValidChildName function to better ensure unique nodeGraph names. Suggestion from @bernardkwok on GitHub PR #1659 Fixes #1659 (Internal change: 2205741)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change(s)
Resolve duplicate names by appending a suffix to nodegraph that encapsulates HdNetwork nodes.
The reason why there are duplicates is that this name and this one are the same. It leads to attempting to create nodegraph with the same name as the already created material node.
Fixes Issue(s)
#1658