Replace boost hash usage with TfHash in pxr/usd/sdf (except SdfPath) #2181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nvmkuruc
changed the title
This was referenced Jan 20, 2023
nvmkuruc
force-pushed
the
sdfhash
branch
4 times, most recently
from
363a7f0
to
98fb89f
Compare
|
Filed as internal issue #USD-7901 |
nvmkuruc
force-pushed
the
sdfhash
branch
2 times, most recently
from
bc30911
to
f1166ba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change(s)
Requires #2173
To remove the dependency of pxr/usd/sdf on boost's hashing functions
__hash__added toSdfAssetPath,SdfPayload,SdfListOp, andSdfReference.SdfListOp,SdfReference,SdfPayload, andSdfValueTypeNameboost::hash_combineusage replaced withTfHash::CombineSdfPathwill be put into its own PR so it's easier to back out this fundamental and commonly hashed type without affecting the rest ofsdfFixes Issue(s)
-#2172 (additional PRs forthcoming)