Fix pxrConfig.cmake #787
Merged
Fix pxrConfig.cmake #787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Filed as internal issue #USD-5136 |
pixar-oss
added a commit
that referenced
this pull request
Mar 27, 2019
Fix pxrConfig.cmake (Internal change: 1948579)
AdamFelt
pushed a commit
to autodesk-forks/USD
that referenced
this pull request
Apr 16, 2024
…nl/OGSMOD-4406 * OGSMOD-4406 run all the unit test, and the filter by TestSkipList * OGSMOD-4406 adjust Ctest timeout and number of jobs. Archive Testing folder on failures and junit now works well on reports generated from xcode * OGSMOD-4406 skip test testSdfListOp on Windows, it takes too long to run on Debug. * OGSMOD-4406 check xcresultparser checksum --------- Co-authored-by: Luis Ehlen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change(s)
Fixes the installation of the pxrConfig.cmake file for both static and shared USD build variants
Fixes Issue(s)
pxrConfig.cmake should enable find_package(pxr) and remove the need to write ad hoc FindUSD.cmake scripts. pxrConfig.cmake references files that were not actually exported, making the config file non-functional
pxrConfig.cmake targets were not set up for a static build at all
Does not address creating a valid pxrConfig.cmake for monolithic builds. usd_m is created by concatenating object files which shouldn't actually be individually exported. A different mechanism, using tricks, is likely necessary to create a pxrConfig.cmake for monolithic builds. According to this issue: https://gitlab.kitware.com/cmake/cmake/issues/17357 - the exact situation of usd_m is not currently supported.