Better ptex glew find #808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Filed as internal issue #USD-5178 |
c64kernal
reviewed
Apr 16, 2019
| "${PTEX_LOCATION}/include/Ptex" | ||
| "${PTEX_LOCATION}/include/wdas" | ||
| "$ENV{PTEX_LOCATION}/include/Ptex" | ||
| "$ENV{PTEX_LOCATION}/include/wdas" |
There was a problem hiding this comment.
It seems like "${PTEX_LOCATION}/include/wdas" and the ENV version are already included above on lines 67 and 69.
There was a problem hiding this comment.
Well spotted, thanks. Fixed in another commit.
There was a problem hiding this comment.
That's great, thanks so much, @charlesfleche
c64kernal
added
the
blocked
c64kernal
added
pending push
and removed
blocked
pixar-oss
added a commit
that referenced
this pull request
Apr 25, 2019
Better ptex glew find (Internal change: 1959855)
AdamFelt
pushed a commit
to autodesk-forks/USD
that referenced
this pull request
Apr 16, 2024
* Enable dawn webgpu build and test. * Remove some cases from skip list as it is fixed and will be merged. * Update skiplist comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change(s)
This PR improves the
FindGLEWandFindPTexcmake modules by allowing searching in customlib64directories for GLEW and PTex include subfolder.Fixes Issue(s)