Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on #265, we discovered that the presence of
omitEmpty
on the CR type definition makes the field optional and therequired
annotation is ignored. This PR fixes it. Opportunistically, we update controller-tools to 0.9.0.PR also updates current installation files. We're adding behavior that should already be there, so no new Thundernetes version is required.
For reference: kubernetes-sigs/controller-tools#599