add a custom_domain attribute for single-user blogs #340
Conversation
Codecov Report
@@ Coverage Diff @@
## master #340 +/- ##
==========================================
+ Coverage 28.29% 28.62% +0.32%
==========================================
Files 62 62
Lines 6545 6603 +58
==========================================
+ Hits 1852 1890 +38
- Misses 4693 4713 +20
Continue to review full report at Codecov.
|
| @@ -183,6 +183,7 @@ table! { | |||
| is_admin -> Bool, | |||
| summary -> Text, | |||
| email -> Nullable<Text>, | |||
| custom_domain -> Nullable<Text>, | |||
There was a problem hiding this comment.
Why is custom_domain NOT NULL in migrations but Nullable here?
Edit: I shall have commented migrations, this should definitely be nullable
There was a problem hiding this comment.
does this mean we can resolve this?
templates/users/new.rs.html
Outdated
| @@ -11,6 +11,7 @@ <h1>@i18n!(ctx.1, "Create an account")</h1> | |||
| <form method="post"> | |||
| @input!(ctx.1, username (text), "Username", form, errors.clone(), "minlenght=\"1\"") | |||
| @input!(ctx.1, email (text), "Email", form, errors.clone()) | |||
| @input!(ctx.1, email (text), "Email", form, errors.clone(), "") | |||
There was a problem hiding this comment.
I think we shouldn't ask for a custom domain when registering (I guess that's what you wanted to do here, even if it looks like you forgot to update what you copied)
There was a problem hiding this comment.
thanks for the catch, i changed this to:
@input!(ctx.1, custom_domain (optional text), "custom_domain", form, errors.clone(), "")and now i get this joyful error:
--> src/template_utils.rs:127:30
|
127 | val = escape(&$form.$name),
| ^^^^^^ expected str, found enum `std::option::Option`
|
::: /home/meena/src/ap/Plume/target/debug/build/plume-7e8607967e0d30ae/out/templates/users/template_new.rs:21:1
|
21 | input!(ctx.1, custom_domain (optional text), "custom_domain", form, errors.clone(), "").to_html(out)?;
| --------------------------------------------------------------------------------------- in this macro invocation
|
= note: expected type `&str`
found type `&std::option::Option<std::string::String>`
error: aborting due to previous error
For more information about this error, try `rustc --explain E0308`.
error: Could not compile `plume`.
There was a problem hiding this comment.
input! don't support Option, make custom_domain (in NewUserForm) not optional, and map it to None whenever it's empty in create(...)
| @@ -0,0 +1,31 @@ | |||
| -- This file should undo anything in `up.sql` | |||
| PRAGMA foreign_keys = ON; | |||
| CREATE TABLE migrate_users_custom_domain ( | |||
There was a problem hiding this comment.
i realized we can give our temporary tables sensible names!
|
With the conclusions that emerged from the discussion (Custom Blog domains and where to attach them) i've decided to close this, and with a better understanding, open a new pull request. Thank you all for helping me with this! |
We want to be able to serve a blog from a custom domain
this PR tries to follow what @BaptisteGelez's describes in #241 #94