Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(scheduling): [MC-1554] Fix same day scheduling from Schedule view #1220

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

nina-py
Copy link
Contributor

@nina-py nina-py commented Oct 3, 2024

Goal

Fix a bug described in the title of this PR.

  • Updated validation rules for scheduledDate to evaluate today's timestamp that is the equivalent of the start of the day, and not any random time that occasionally prevented curators from schedulind.

  • Updated validation messages to provide feedback to users when form validation fails.

  • Removed an outdated prospect source from tests.

Reference

https://mozilla-hub.atlassian.net/browse/MC-1554

@nina-py nina-py requested a review from a team as a code owner October 3, 2024 04:13
- Updated validation rules for `scheduledDate` to evaluate today's timestamp
that is the equivalent of the start of the day, and not any random time
that occasionally prevented curators from schedulind.

- Updated validation messages to provide feedback to users when form
validation fails.

- Removed an outdated prospect source from tests.
@nina-py nina-py force-pushed the MC-1554-fix-same-day-scheduling-from-schedule-view branch from 15ab872 to aa490bf Compare October 3, 2024 04:18
Copy link
Contributor

@katerinachinnappan katerinachinnappan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay! ✨🔥

@nina-py nina-py merged commit 047fba7 into main Oct 3, 2024
6 checks passed
@nina-py nina-py deleted the MC-1554-fix-same-day-scheduling-from-schedule-view branch October 3, 2024 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants