Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Django 4 to CI #18

Merged
merged 1 commit into from
Jan 18, 2022
Merged

Add Django 4 to CI #18

merged 1 commit into from
Jan 18, 2022

Conversation

amureki
Copy link
Contributor

@amureki amureki commented Jan 5, 2022

Greetings @PokaInc

I am introducing this small PR to see if Django 4.0 test run would pass and get a bit of your input on this repository.
We definitely can bring some love here, switch CI to GitHub Actions and remove deprecated and obsolete Python and Django versions. This is not a big deal, but it would be nice to get a green light from maintainers before anyone would proceed with such changes.
What do you think?

@JeffLabonte JeffLabonte self-requested a review January 6, 2022 18:02
Copy link

@JeffLabonte JeffLabonte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally, I feel like it would make sense to make those changes, but I would wait for another of my colleague to give it the go.

Copy link

@cdumontvincent cdumontvincent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not see a problem to support django 4.

@alexandredufour alexandredufour merged commit 2cb51ee into PokaInc:master Jan 18, 2022
@amureki amureki deleted the django4 branch January 19, 2022 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants