Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix fee withdrawal validation #139

Merged
merged 2 commits into from
Dec 29, 2023
Merged

Fix fee withdrawal validation #139

merged 2 commits into from
Dec 29, 2023

Conversation

lrazovic
Copy link
Member

@lrazovic lrazovic commented Dec 29, 2023 •
edited
Loading

The FungibleAdapter needs an extra safety check until this is merged and put in a release branch. paritytech/polkadot-sdk#2823

Otherwise users are able to use their Frozen balance to pay fees and/or tips.

@lrazovic lrazovic self-assigned this Dec 29, 2023
vstam1
vstam1 approved these changes Dec 29, 2023
View reviewed changes
Copy link
Collaborator

@vstam1 vstam1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add TODO comment to update this once we updated to the appropriate substrate version so we don't forget!

@lrazovic lrazovic merged commit 886c527 into main Dec 29, 2023
@JuaniRios JuaniRios deleted the fix/ensure-can-withdraw branch March 26, 2024 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstam1 vstam1 vstam1 approved these changes

@JuaniRios JuaniRios Awaiting requested review from JuaniRios

Assignees

@lrazovic lrazovic

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lrazovic @vstam1