Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lmdb: add lmdb management #95

Merged
merged 4 commits into from
Feb 11, 2021
Merged

lmdb: add lmdb management #95

merged 4 commits into from
Feb 11, 2021

Conversation

SrX
Copy link
Contributor

@SrX SrX commented Feb 11, 2021

Management of directory and files for LMDB database.

@SrX SrX requested a review from Habbie February 11, 2021 07:40
@SrX SrX self-assigned this Feb 11, 2021
Copy link
Member

@Habbie Habbie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, but fixing permissions on LMDB databases should not be Ansible's job. You'd have to run this after every domain creation via pdnsutil.

README.md Outdated Show resolved Hide resolved
Co-authored-by: Peter van Dijk <[email protected]>
@SrX
Copy link
Contributor Author

SrX commented Feb 11, 2021

This looks good, but fixing permissions on LMDB databases should not be Ansible's job. You'd have to run this after every domain creation via pdnsutil.

This part could be removed, I also have my doubts about this, because number of shards can be very high and this task will take to much time. I just mimic same behaviour as for sqlite3. I'll update the role and do some test.

@Habbie
Copy link
Member

Habbie commented Feb 11, 2021

Ah, but for sqlite3 one time is enough, is the difference of course.

@SrX SrX merged commit a04a06e into master Feb 11, 2021
@Habbie Habbie deleted the lmdb_database_dir branch February 11, 2021 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants