Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add worker service for handling overdue borrow request #191

Closed
wants to merge 3 commits into from
Closed

feat: add worker service for handling overdue borrow request #191

wants to merge 3 commits into from

Conversation

Vzart
Copy link
Contributor

@Vzart Vzart commented Jun 6, 2023

No description provided.

@Vzart Vzart added the enhancement New feature or request label Jun 6, 2023
@Vzart Vzart added this to the Iteration 2 milestone Jun 6, 2023
@Vzart Vzart requested a review from ChienNQuang June 6, 2023 08:59
@Vzart Vzart self-assigned this Jun 6, 2023
@Vzart Vzart linked an issue Jun 6, 2023 that may be closed by this pull request
Handle overdue request #190
Open
@Vzart Vzart modified the milestones: Iteration 2, Iteration 3 Jun 6, 2023
kaitoz11
kaitoz11 suggested changes Jun 6, 2023
View reviewed changes
Copy link
Member

@kaitoz11 kaitoz11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hahaaa

src/Api/Services/BorrowRequestService.cs Outdated Show resolved Hide resolved
@Vzart Vzart requested a review from kaitoz11 June 6, 2023 15:56
ChienNQuang
ChienNQuang requested changes Jun 7, 2023
View reviewed changes
Copy link
Member

@ChienNQuang ChienNQuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few things should be adjusted

src/Api/Services/BorrowRequestService.cs Outdated Show resolved Hide resolved
kaitoz11
kaitoz11 suggested changes Jun 10, 2023
View reviewed changes
Copy link
Member

@kaitoz11 kaitoz11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please do something @Vzart

src/Api/Services/BorrowRequestService.cs Outdated Show resolved Hide resolved
kaitoz11
kaitoz11 approved these changes Jul 10, 2023
View reviewed changes
Copy link
Member

@kaitoz11 kaitoz11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Vzart Vzart closed this Jul 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaitoz11 kaitoz11 kaitoz11 approved these changes

@ChienNQuang ChienNQuang Awaiting requested review from ChienNQuang

Assignees

@Vzart Vzart

Labels
enhancement New feature or request
Projects
None yet
Milestone
Iteration 3
Development

Successfully merging this pull request may close these issues.

Handle overdue request
3 participants
@Vzart @kaitoz11 @ChienNQuang