Volume is boundless

[FossPrime]

Volume seems to go up to 11, causing distortion... well more like 10000%. The issue is that you never know if the volume is at 100%, specially when you listen to electronica.

I'll look into this and get back to you, I might just fix it my self.

[FossPrime]

One line solution. On the other hand, volume down is also boundless.

app->player.scale = BarPlayerCalcScale (app->player.gain + ( app->settings.volume <= 0 ? app->settings.volume : --app->settings.volume));

[PromyLOPh]

I’ve no idea how to do this “correctly”. At the moment it’s just an ugly hack.

What do you define as “100%”, btw? settings.volume == 0?

[FossPrime]

It's a hack if you consider the distortion a bug, you could call it a "digital boost support" feature for the libpiano. Clearly it is not a feature for the Pianobar front-end, if that's the case then that code is the right path.

0 is 100%, volume down seems to have some sort of logarithmic slope that never actually reaches 0%, although at 42 its pretty dead. So the question is, is it a bug, or a feature?

[PromyLOPh]

It's a hack if you consider the distortion a bug, you could call it a
"digital boost support" feature for the libpiano. Clearly it is not a
feature for the Pianobar front-end, if that's the case then that code
is the right path.
Uh, libpiano has nothing to do with it. See applyReplayGain in
src/player.c