Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

multi role support #23

Merged
merged 2 commits into from
Apr 23, 2024
Merged

multi role support #23

merged 2 commits into from
Apr 23, 2024

Conversation

mrmauer
Copy link
Contributor

@mrmauer mrmauer commented Apr 3, 2024 •
edited
Loading

Notion

Tests

  • added unit tests to cover multi-role cases
  • smoke tested with an example app that the user token is getting parsed correctly
  • fixed a bug in unit tests that made all OrgMemberInfo instance point to the same object

andrew-propelauth
andrew-propelauth approved these changes Apr 23, 2024
View reviewed changes
Copy link
Contributor

@andrew-propelauth andrew-propelauth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mrmauer mrmauer merged commit 52a50d8 into main Apr 23, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrew-propelauth andrew-propelauth andrew-propelauth approved these changes

@itailevi98 itailevi98 Awaiting requested review from itailevi98

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mrmauer @andrew-propelauth