Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow later numpy versions #124

Merged
merged 2 commits into from
Oct 14, 2024
Merged

Allow later numpy versions #124

merged 2 commits into from
Oct 14, 2024

Conversation

N-Wouda
Copy link
Member

@N-Wouda N-Wouda commented Oct 13, 2024

Closes #123.

@N-Wouda N-Wouda requested a review from leonlan October 13, 2024 16:38
Comment on lines -20 to -21
[pytest]
pythonpath = [".", "vrplib"]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not a legal pyproject key - should be tool.pytest.ini_options

"""
Checks if a deprecation warning is raised when the function is called.
"""
with pytest.warns(DeprecationWarning):
download_instance("X-n101-k25", "tmp")
download_instance("X-n101-k25", tmp_path / "tmp")
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before I changed it, these tests would dump a tmp file in the project root. That's a bit annoying :).

Copy link
Member

@leonlan leonlan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@leonlan leonlan merged commit 74d4b6d into main Oct 14, 2024
5 checks passed
@leonlan leonlan deleted the allow-later-numpy-versions branch October 14, 2024 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow numpy 2
2 participants