Adds pyproject file. #204
Closed
Adds pyproject file. #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes it possible to install the software with pip, compliant with https://www.python.org/dev/peps/pep-0518/. Previously, users of the software might have encountered situations like that described here: pypa/pip#5761 (in fact, I encountered that...). This fix should resolve that with modern versions of pip.
agramfort
approved these changes
Jul 26, 2020
|
Hello @arokem , the doc build seams to fail because of the pyproject (complains about missing stuff). Could you have a look please? |
|
Sorry about this: I do not have the bandwidth to look into this. I will go ahead and close this PR so that you can add PEP518 compliance in a separate PR, if/when that becomes a priority for the project. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Motivation and context / Related issue
This resolves issues like the ones described in #59, by making the software compliant with PEP518
How has this been tested (if it applies)
Locally on my laptop in a clean env and on an automated build system that uses repo2docker.
Checklist