Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick and probably nasty kludge to introduce increased entropy method… #3

Merged
merged 6 commits into from
Jun 29, 2022

Conversation

Oneiroi
Copy link
Contributor

@Oneiroi Oneiroi commented Jun 28, 2022

… for the sessionStoreKey

main.go Outdated Show resolved Hide resolved
util/util.go Outdated Show resolved Hide resolved
util/util.go Outdated Show resolved Hide resolved
@Oneiroi
Copy link
Contributor Author

Oneiroi commented Jun 28, 2022

this has not been functionally tested at this moment in time please lmk if there is some areas I have missed, thanks!

@Oneiroi
Copy link
Contributor Author

Oneiroi commented Jun 28, 2022

improvement for #2 to raise entropy shannon scale to ~6.02 for sessionStoreKey

@Oneiroi
Copy link
Contributor Author

Oneiroi commented Jun 28, 2022

Yeah I've a lot to cleanup here, bare with me 😓

…ewrite similar logic, now to make it work with the rest of the codebase 😓
…ewrite similar logic, now to make it work with the rest of the codebase 😓
@Oneiroi
Copy link
Contributor Author

Oneiroi commented Jun 28, 2022

alright @pdavies011010 please t.a.l, I suspect this is probably horrible, however this should be tested and if functional can be merged 👍

Copy link
Contributor

@pdavies011010 pdavies011010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @Oneiroi , if you just want to remove those two functions we'll get this merged in and tested

util/util.go Outdated
}
return base64.RawURLEncoding.EncodeToString(challenge)
}

// Generate a random string of alpha characters of length n
func RandStringBytesRmndr(n int) []byte {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Oneiroi Yep looks like you can remove RandInit and RandStringBytesRmndr

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed within #f7f4776

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

over to you @pdavies011010 🙇

@pdavies011010 pdavies011010 merged commit a36d0f0 into Quiq:main Jun 29, 2022
@Oneiroi Oneiroi deleted the entropy_enhancements branch June 29, 2022 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants