Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing tests on FE310 (Hifive1b) #13086

Open
aabadie opened this issue Jan 10, 2020 · 8 comments
Open

Failing tests on FE310 (Hifive1b) #13086

aabadie opened this issue Jan 10, 2020 · 8 comments
Labels
Area: cpu Area: CPU/MCU ports Platform: RISC-V Platform: This PR/issue effects RISC-V-based platforms Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)

Comments

@aabadie
Copy link
Contributor

aabadie commented Jan 10, 2020

Description

Opening this issue for tracking the problems with tests found in #12934. Detailed issues can be found here.

See #12934 (comment) for some insight.

Steps to reproduce the issue

./dist/tools/compile_and_test_for_board/compile_and_test_for_board.py . hifive1b --jobs=4

Expected results

No failure

Actual results

Failures during test:
- [examples/lorawan](examples/lorawan/test.failed)
- [tests/gnrc_ipv6_ext_opt](tests/gnrc_ipv6_ext_opt/test.failed)
- [tests/gnrc_ipv6_fwd_w_sub](tests/gnrc_ipv6_fwd_w_sub/test.failed)
- [tests/gnrc_ipv6_nib_dns](tests/gnrc_ipv6_nib_dns/test.failed)
- [tests/gnrc_sixlowpan_frag](tests/gnrc_sixlowpan_frag/test.failed)
- [tests/periph_wdt](tests/periph_wdt/test.failed)
- [tests/pkg_heatshrink](tests/pkg_heatshrink/test.failed)
- [tests/pkg_semtech-loramac](tests/pkg_semtech-loramac/test.failed)
- [tests/pkg_utensor](tests/pkg_utensor/test.failed)
- [tests/ps_schedstatistics](tests/ps_schedstatistics/test.failed)
- [tests/xtimer_now_irq](tests/xtimer_now_irq/test.failed)
- [tests/xtimer_periodic_wakeup](tests/xtimer_periodic_wakeup/test.failed)
- [tests/xtimer_usleep](tests/xtimer_usleep/test.failed)

Versions

current master

@aabadie aabadie added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) Platform: RISC-V Platform: This PR/issue effects RISC-V-based platforms Area: cpu Area: CPU/MCU ports labels Jan 10, 2020
@fjmolinas
Copy link
Contributor

With #13182 I got these results:

ERROR:hifive1b:Tests failed: 6
Failures during test:
- [tests/cpp11_mutex](tests/cpp11_mutex/test.failed)
- [tests/gnrc_ipv6_fwd_w_sub](tests/gnrc_ipv6_fwd_w_sub/test.failed)
- [tests/pkg_utensor](tests/pkg_utensor/test.failed)
- [tests/ps_schedstatistics](tests/ps_schedstatistics/test.failed)
- [tests/xtimer_periodic_wakeup](tests/xtimer_periodic_wakeup/test.failed)
- [tests/xtimer_usleep](tests/xtimer_usleep/test.failed)

@aabadie
Copy link
Contributor Author

aabadie commented Jul 2, 2020

I have new results:

ERROR:hifive1b:Tests failed: 13
Failures during test:
- [examples/lorawan](examples/lorawan/test.failed)
- [tests/gnrc_ipv6_ext_opt](tests/gnrc_ipv6_ext_opt/test.failed)
- [tests/gnrc_ipv6_fwd_w_sub](tests/gnrc_ipv6_fwd_w_sub/test.failed)
- [tests/gnrc_ipv6_nib_dns](tests/gnrc_ipv6_nib_dns/test.failed)
- [tests/gnrc_sixlowpan_frag](tests/gnrc_sixlowpan_frag/test.failed)
- [tests/periph_wdt](tests/periph_wdt/test.failed)
- [tests/pkg_heatshrink](tests/pkg_heatshrink/test.failed)
- [tests/pkg_semtech-loramac](tests/pkg_semtech-loramac/test.failed)
- [tests/pkg_utensor](tests/pkg_utensor/test.failed)
- [tests/ps_schedstatistics](tests/ps_schedstatistics/test.failed)
- [tests/xtimer_now_irq](tests/xtimer_now_irq/test.failed)
- [tests/xtimer_periodic_wakeup](tests/xtimer_periodic_wakeup/test.failed)
- [tests/xtimer_usleep](tests/xtimer_usleep/test.failed)

The cpp tests are working now.

@miri64 miri64 added this to the Release 2020.07 milestone Jul 6, 2020
@fjmolinas
Copy link
Contributor

fjmolinas commented Jul 21, 2020

During release testing I found that tests/periph_wdt is failing as well: Ups was aready in the list.

@aabadie
Copy link
Contributor Author

aabadie commented Feb 8, 2021

New tests are failing in master: tests/event_wait_timeout, tests/thread_flags and tests/thread_flags_xtimer. As reported in #15718 (comment). These regressions were introduced by #15736.

The current situation is:

ERROR:hifive1b:Tests failed: 10
Failures during test:
- [tests/event_wait_timeout](tests/event_wait_timeout/test.failed)
- [tests/gnrc_ipv6_fwd_w_sub](tests/gnrc_ipv6_fwd_w_sub/test.failed)
- [tests/periph_wdt](tests/periph_wdt/test.failed)
- [tests/pkg_utensor](tests/pkg_utensor/test.failed)
- [tests/ps_schedstatistics](tests/ps_schedstatistics/test.failed)
- [tests/sys_architecture](tests/sys_architecture/test.failed)
- [tests/thread_flags](tests/thread_flags/test.failed)
- [tests/thread_flags_xtimer](tests/thread_flags_xtimer/test.failed)
- [tests/xtimer_periodic_wakeup](tests/xtimer_periodic_wakeup/test.failed)
- [tests/xtimer_usleep](tests/xtimer_usleep/test.failed)

tests/sys_architecture is also a new one.

@aabadie
Copy link
Contributor Author

aabadie commented Feb 25, 2021

After #15958 got merged, I retested the failing tests mentioned above and here is the new situation:

ERROR:hifive1b:Tests failed: 5
Failures during test:
- [tests/gnrc_ipv6_fwd_w_sub](tests/gnrc_ipv6_fwd_w_sub/test.failed)
- [tests/periph_wdt](tests/periph_wdt/test.failed)
- [tests/ps_schedstatistics](tests/ps_schedstatistics/test.failed)
- [tests/xtimer_periodic_wakeup](tests/xtimer_periodic_wakeup/test.failed)
- [tests/xtimer_usleep](tests/xtimer_usleep/test.failed)

@MrKevinWeiss MrKevinWeiss removed this from the Release 2021.07 milestone Jul 15, 2021
@aabadie
Copy link
Contributor Author

aabadie commented Jan 9, 2023

After #19112 was merged, I thought it would be useful to give compile_and_test_for_board.py a shot on hifive1b. Here is a fresh list of failures:

Failures during test:
- [tests/congure_quic](tests/congure_quic/test.failed)
- [tests/gcoap_dns](tests/gcoap_dns/test.failed)
- [tests/gnrc_ipv6_fwd_w_sub](tests/gnrc_ipv6_fwd_w_sub/test.failed)
- [tests/gnrc_netif_ipv6_wait_for_global_address](tests/gnrc_netif_ipv6_wait_for_global_address/test.failed)
- [tests/malloc_thread_safety](tests/malloc_thread_safety/test.failed)
- [tests/periph_rtc](tests/periph_rtc/test.failed)
- [tests/periph_wdt](tests/periph_wdt/test.failed)
- [tests/pkg_qdsa](tests/pkg_qdsa/test.failed)
- [tests/ps_schedstatistics](tests/ps_schedstatistics/test.failed)
- [tests/sys_sema_inv](tests/sys_sema_inv/test.failed)
- [tests/xtimer_periodic_wakeup](tests/xtimer_periodic_wakeup/test.failed)
- [tests/xtimer_usleep](tests/xtimer_usleep/test.failed)

@aabadie
Copy link
Contributor Author

aabadie commented Jan 9, 2023

With this change:

git diff
diff --git a/cpu/fe310/include/periph_cpu.h b/cpu/fe310/include/periph_cpu.h
index ee9c02d892..e022319032 100644
--- a/cpu/fe310/include/periph_cpu.h
+++ b/cpu/fe310/include/periph_cpu.h
@@ -167,7 +167,7 @@ typedef struct {
 #define RTT_MIN_FREQUENCY   (1U)                    /* in Hz */
 
 #ifndef RTT_FREQUENCY
-#define RTT_FREQUENCY       (RTT_MAX_FREQUENCY)     /* in Hz */
+#define RTT_FREQUENCY       (RTT_MIN_FREQUENCY)     /* in Hz */
 #endif
 
 /**

The failing tests falls down to:

Failures during test:
- [tests/gnrc_ipv6_fwd_w_sub](tests/gnrc_ipv6_fwd_w_sub/test.failed)
- [tests/gnrc_netif_ipv6_wait_for_global_address](tests/gnrc_netif_ipv6_wait_for_global_address/test.failed)
- [tests/malloc_thread_safety](tests/malloc_thread_safety/test.failed)
- [tests/periph_wdt](tests/periph_wdt/test.failed)
- [tests/pkg_qdsa](tests/pkg_qdsa/test.failed)
- [tests/ps_schedstatistics](tests/ps_schedstatistics/test.failed)
- [tests/sys_sema_inv](tests/sys_sema_inv/test.failed)
- [tests/xtimer_periodic_wakeup](tests/xtimer_periodic_wakeup/test.failed)
- [tests/xtimer_usleep](tests/xtimer_usleep/test.failed)

Note that the diff above corresponds to the situation before #14741 was merged and according to #14878 (review), tests/periph_rtc is broken for hifive1b in master since #14741.

@maribu
Copy link
Member

maribu commented May 19, 2023

Would you mind given this another spin?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: cpu Area: CPU/MCU ports Platform: RISC-V Platform: This PR/issue effects RISC-V-based platforms Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)
Projects
None yet
Development

No branches or pull requests

5 participants