Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

examples: use coap_opt_finish() in gcoap based examples #10926

Merged
merged 3 commits into from
Mar 13, 2019

Conversation

kb2ma
Copy link
Member

@kb2ma kb2ma commented Feb 1, 2019

Contribution description

#10892 updates gcoap documentation and internal message generation to use coap_opt_finish() rather than gcoap_finish(). This PR updates RIOT examples that use gcoap to also use coap_opt_finish(). The examples include the gcoap CLI example, cord_epsim, and cord_ep.

Testing procedure

  • gcoap cli: Send requests to the CLI for /riot/stats and /riot/board. Use the CLI to send a request. Have an Observe client register for /cli/stats, and then create another request in the CLI, which will send a notification to the observer.
  • cord_epsim: Register with a resource directory server. Also, send requests to the cord_epsim endpoint itself for /riot/foo and /riot/info.
  • cord_ep: Use the CLI to register with a resource directory server. Also use the CLI to discover RD servers and remove the cord_ep client from the server. Also, send requests to the cord_ep endpoint itself for /sense/temp and /node/info.

FWIW, review my request_response, cord_ep, and cord_epsim automated tests for examples.

Issues/PRs references

Depends on #10892

@kb2ma kb2ma added Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation Area: CoAP Area: Constrained Application Protocol implementations labels Feb 1, 2019
@kb2ma kb2ma mentioned this pull request Feb 15, 2019
6 tasks
@kb2ma kb2ma added this to the Release 2019.04 milestone Feb 24, 2019
@kaspar030 kaspar030 added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Mar 12, 2019
Copy link
Contributor

@kaspar030 kaspar030 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK.

tested gcoap, unittests, cord_ep (against aiocoap-rd). cord_epsim didn't show up in the endpoints of aiocoap-rd, but that might be aiocoap not speaking the protocol?

@kaspar030
Copy link
Contributor

@haukepetersen could you take a quick look at this?

@kaspar030
Copy link
Contributor

@kb2ma this needs a rebase.

@kb2ma
Copy link
Member Author

kb2ma commented Mar 13, 2019

My pleasure, thanks for the review.

@haukepetersen
Copy link
Contributor

Successfully tested the cord_epsim example locally, so everything is fine with this PR.

ACK and go :-)

@haukepetersen haukepetersen merged commit e8d06ba into RIOT-OS:master Mar 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: CoAP Area: Constrained Application Protocol implementations CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants