Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gnrc_sixlowpan_frag: replace printf with DEBUG #11135

Merged
merged 1 commit into from
Mar 7, 2019
Merged

gnrc_sixlowpan_frag: replace printf with DEBUG #11135

merged 1 commit into from
Mar 7, 2019

Conversation

miri64
Copy link
Member

@miri64 miri64 commented Mar 7, 2019

Contribution description

In #10679 there was a printf() introduced accidentally. This changes that to a DEBUG().

Testing procedure

gnrc_networking should still compile, it's size might shrink a bit but should not grow.

Issues/PRs references

Follow-up to #10679.

@miri64 miri64 added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) Area: network Area: Networking CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Mar 7, 2019
@miri64 miri64 added this to the Release 2019.04 milestone Mar 7, 2019
@miri64 miri64 requested a review from gschorcht March 7, 2019 17:20
@miri64 miri64 added the Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer label Mar 7, 2019
@maribu maribu added Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines Reviewed: 5-documentation The documentation details of the PR were reviewed according to the maintainer guidelines labels Mar 7, 2019
maribu
maribu approved these changes Mar 7, 2019
View reviewed changes
Copy link
Member

@maribu maribu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Untested ACK

@maribu maribu merged commit 6157244 into RIOT-OS:master Mar 7, 2019
@miri64 miri64 deleted the gnrc_sixlowpan_frag/fix/rm-printf branch March 7, 2019 19:32
This was referenced Mar 8, 2019
Merged
Merged
@danpetry danpetry modified the milestone: Release 2019.04 Mar 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maribu maribu maribu approved these changes

@gschorcht gschorcht Awaiting requested review from gschorcht

Assignees
No one assigned
Labels
Area: network Area: Networking CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines Reviewed: 5-documentation The documentation details of the PR were reviewed according to the maintainer guidelines Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)
Projects
None yet
Milestone
Release 2019.04
Development

Successfully merging this pull request may close these issues.
3 participants
@miri64 @maribu @danpetry