Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sys/random: add missing includes #11327

Merged
merged 1 commit into from
Apr 1, 2019
Merged

sys/random: add missing includes #11327

merged 1 commit into from
Apr 1, 2019

Conversation

kaspar030
Copy link
Contributor

Contribution description

sys/random.c was using both assert() and bitarithm_msb() without including the corresponding headers.

Testing procedure

Plain' old looking at code should suffice. Code worked before probably because both headers were included from somewhere else.

Issues/PRs references

none

@kaspar030 kaspar030 added Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Area: security Area: Security-related libraries and subsystems labels Apr 1, 2019
miri64
miri64 approved these changes Apr 1, 2019
View reviewed changes
Copy link
Member

@miri64 miri64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed that those functions are used in random.c but not included. ACK

@dylad dylad added this to the Release 2019.04 milestone Apr 1, 2019
@dylad dylad merged commit d6cad3c into RIOT-OS:master Apr 1, 2019
@kaspar030 kaspar030 deleted the random_add_missing_include branch July 5, 2019 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miri64 miri64 miri64 approved these changes

Assignees

@miri64 miri64

Labels
Area: security Area: Security-related libraries and subsystems CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer
Projects
None yet
Milestone
Release 2019.04
Development

Successfully merging this pull request may close these issues.
3 participants
@kaspar030 @miri64 @dylad