cpu/nrf5x/nrfmin: fix isr termination #11395
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
The nrfmin driver had a serious bug terminating the interrupt handler in case of an invalid CRC value.
Instead of closing with
cortexm_isr_end();
it just returned, which resulted in unwanted behaviour.This PR fixes one error mentioned in #10878 and is based on the solution of @pystub
Testing procedure
Testing should at least involve receiving and then sending packets with a valid CRC. However, it is appreciated if a reviewer makes sure that the behaviour is also correct with invalid CRC.
Make sure to test it using nrfmin with
USEMODULE=nrfmin
on nrf5x boards.