Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

examples/suit_update: improve test script #12149

Merged
merged 1 commit into from
Dec 2, 2019
Merged

examples/suit_update: improve test script #12149

merged 1 commit into from
Dec 2, 2019

Conversation

fjmolinas
Copy link
Contributor

@fjmolinas fjmolinas commented Sep 2, 2019 •
edited
Loading

Contribution description

This PR extends the example test to verify sequence number and signature validation is performed correctly.

Because of #11988 we first ping the node. If not aiocoap resends the first "trigger" since it doesn't receive the ACK this results in receiving the same manifest twice which means the second test fails since the signature is still invalid.

Testing procedure

Follow examples/suit_update/README Automatic test section.

Issues/PRs references

Depends on #11818
Related to #11988

@fjmolinas fjmolinas added Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation State: waiting for other PR State: The PR requires another PR to be merged first Area: OTA Area: Over-the-air updates labels Sep 2, 2019
@fjmolinas fjmolinas removed the State: waiting for other PR State: The PR requires another PR to be merged first label Oct 21, 2019
@fjmolinas fjmolinas requested review from aabadie and removed request for aabadie October 21, 2019 12:44
@fjmolinas fjmolinas requested review from aabadie and removed request for aabadie November 29, 2019 13:22
@fjmolinas
examples/suit_update: improve test script
09a5282 
- Verify smaller image sequence numbers are rejected
- Verify invalid signatures are rejected
@aabadie aabadie added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: run tests If set, CI server will run tests on hardware for the labeled PR labels Dec 2, 2019
@aabadie aabadie mentioned this pull request Dec 2, 2019
Merged
aabadie
aabadie approved these changes Dec 2, 2019
View reviewed changes
Copy link
Contributor

@aabadie aabadie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good now. Tested locally and Murdock is also green.

ACK and go!

@aabadie aabadie merged commit e0b7c2d into RIOT-OS:master Dec 2, 2019
@fjmolinas fjmolinas added this to the Release 2020.01 milestone Dec 13, 2019
@fjmolinas fjmolinas deleted the pr_suit_test branch July 31, 2020 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aabadie aabadie aabadie approved these changes

@kaspar030 kaspar030 Awaiting requested review from kaspar030

Assignees
No one assigned
Labels
Area: OTA Area: Over-the-air updates CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: run tests If set, CI server will run tests on hardware for the labeled PR Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation
Projects
None yet
Milestone
Release 2020.01
Development

Successfully merging this pull request may close these issues.
2 participants
@fjmolinas @aabadie