Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

boards/common/msba2: Add MINITERMFLAGS to avoid reset #13917

Merged
merged 2 commits into from
Apr 22, 2020
Merged

boards/common/msba2: Add MINITERMFLAGS to avoid reset #13917

merged 2 commits into from
Apr 22, 2020

Conversation

leandrolanzieri
Copy link
Contributor

Contribution description

This adds the variable MINITERMFLAGS analog to PYTERMFLAGS, which allows adding extra flags to the terminal when using miniterm.py. This is needed in the case of the msba2 which requires RTS and DTR lines to be 0.

Testing procedure

Run some application on the msba2, that uses miniterm (e.g. examples/micropython) or specify RIOT_TERMINAL = miniterm. With this PR it should work.

Issues/PRs references

Found while running tests for RIOT-OS/Release-Specs#152

@leandrolanzieri leandrolanzieri added Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation Area: build system Area: Build system Area: tools Area: Supplementary tools labels Apr 21, 2020
@leandrolanzieri leandrolanzieri added this to the Release 2020.07 milestone Apr 21, 2020
@leandrolanzieri leandrolanzieri added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Apr 21, 2020
@benpicco
Copy link
Contributor

benpicco commented Apr 21, 2020 •
edited
Loading

Tested on mcb2388, works like a charm (when moved to the common location).

Btw.: First I got Terminal program miniterm.py is required but not found in PATH. Aborting..
I had to manually add /usr/lib/python3/dist-packages/serial/tools to my PATH.

@leandrolanzieri leandrolanzieri changed the title boards/msba2: Add MINITERMFLAGS to avoid reset boards/common/msba2: Add MINITERMFLAGS to avoid reset Apr 21, 2020
@leandrolanzieri leandrolanzieri added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) and removed Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation labels Apr 22, 2020
@leandrolanzieri
Copy link
Contributor Author

leandrolanzieri commented Apr 22, 2020 •
edited
Loading

@benpicco I applied the latest suggested change, please take another look :)

maribu
maribu approved these changes Apr 22, 2020
View reviewed changes
Copy link
Member

@maribu maribu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK. Tested examples/micropython on a MSB-A2. Works like a charm.

@maribu maribu merged commit 5663302 into RIOT-OS:master Apr 22, 2020
@leandrolanzieri leandrolanzieri deleted the pr/miniterm/flags branch April 22, 2020 08:00
@leandrolanzieri leandrolanzieri added the Process: needs backport Integration Process: The PR is required to be backported to a release or feature branch label Apr 22, 2020
@leandrolanzieri leandrolanzieri mentioned this pull request Apr 22, 2020
Merged
@leandrolanzieri
Copy link
Contributor Author

Backport provided in #13921

@leandrolanzieri leandrolanzieri mentioned this pull request Apr 22, 2020
Closed
81 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benpicco benpicco benpicco approved these changes

@maribu maribu maribu approved these changes

@aabadie aabadie Awaiting requested review from aabadie

@fjmolinas fjmolinas Awaiting requested review from fjmolinas

Assignees
No one assigned
Labels
Area: build system Area: Build system Area: tools Area: Supplementary tools CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Process: needs backport Integration Process: The PR is required to be backported to a release or feature branch Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)
Projects
None yet
Milestone
Release 2020.04
Development

Successfully merging this pull request may close these issues.
3 participants
@leandrolanzieri @benpicco @maribu