make: fix FEATURES_REQUIRED and FEATURES_PROVIDED a bit
#1879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #1876 This PR introduces `FEATURES_OPTIONAL` which can be used to tell the Make system, that the application would like to use some feature, but the build should proceed even if the selected board cannot provide the optional feature. `make buildtest` and `make info-supported-boards` heed this variable when examining the list of supported boards. If a word is present in `FEATURES_REQUIRED` and `FEATURES_OPTIONAL`, then `FEATURES_OPTIONAL` takes precedence.
All used feature requests (both in `FEATURES_REQUIRED` and `FEATURES_OPTIONAL`) that could be satisfied get exposed to C with `-DFEATURE_ABC`.
Kijewski
added
Area: build system
This change allows drivers (or any module for that matter) to provide
features. This is e.g. useful if a board does not have a transceiver,
but your application uses `USEMODULE += some_driver`, which implements
the transceiver interface.
The line `FEATURES_PROVIDED += some_feature` should go to the guarded
block in `{sys,drivers}/Makefile.include`.
|
Shouldn't this be split up into two PRs? |
Nah, it would needlessly add overhead for me to maintain two PRs. |
|
Looks good. This is half-an-ACK, because my Kung-Fu is not strong enough. |
|
ACK |
LudwigKnuepfer
added a commit
that referenced
this pull request
Oct 28, 2014
make: fix `FEATURES_REQUIRED` and `FEATURES_PROVIDED` a bit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-DFEATURE_ABCFEATURES_PROVIDED(requested in drivers/nrf24l01+ : added netdev implementation for nrf24l01+ transceiver #1808)See individual diffs for more information.