Samr21: cpuid implementation #2052

Troels51 · 2014-11-20T10:22:39Z

Reading the 128bit serial number in the samd21 by copying it from memory addresses that point to non-volatile memory.
The addresses come from section 8.3.3 in the datasheet.

thomaseichinger · 2014-11-20T10:42:16Z

cpu/samd21/include/cpu-conf.h

+/**
+ * @name CPUID_ID_LEN length of cpuid in bytes
+ * @{
+*/


please add a space here.

thomaseichinger · 2014-11-20T10:46:19Z

Two minor comment above. You also need to periph_cpuid to the board's Makefile.features.

Troels51 · 2014-11-20T11:03:49Z

Rebased, and added changes based on your comments

thomaseichinger · 2014-11-20T14:04:27Z

Needs another rebase because of #2051

mehlis · 2014-11-23T09:39:15Z

cpu/samd21/periph/cpuid.c

+#include "cpu-conf.h"
+#include "periph/cpuid.h"
+
+#define Word0 (*(volatile uint32_t *)0x0080A00C)


better put a prefix on this generic name, and usualy we write constansts all upcase letters

@Troels51 please address this comment

Another remark: usually these addresses are defined in some header, e.g. cpu/samd21/include/component/component_cpuid.h

thomaseichinger · 2014-11-25T18:47:29Z

needs rebase because of #2053

miri64 · 2014-12-06T19:21:17Z

cpu/samd21/include/cpu-conf.h

@@ -48,5 +48,11 @@
 /** @} */


+/**
+ * @name CPUID_ID_LEN length of cpuid in bytes
+ * @{


@name and and braces not needed. Just document with

/** * @brief Length of CPU ID in bytes */

thomaseichinger · 2014-12-08T12:27:39Z

@Troels51 please address comments and rebase.

Troels51 · 2014-12-15T14:21:36Z

Sorry for being a bit slow, i addressed the comments and rebased+squashed

miri64 · 2014-12-15T14:24:23Z

Still needs rebase to current master.

miri64 · 2014-12-15T14:25:25Z

+ please squash only when the reviewing is done. Otherwise it can get hard to trace your changes since the last time someone looked at your code ;-)

Troels51 · 2014-12-15T14:31:00Z

Right, my bad :)

miri64 · 2014-12-15T15:12:33Z

cpu/samd21/periph/cpuid.c

@@ -0,0 +1,17 @@
+


License header missing.

N8Fear · 2014-12-17T00:05:34Z

I think if you wrote the code you're the copyright holder in the first place. You're free to concede it to someone (person or organization) else.
Unless you actually want to do that you should replace "Freie Universität Berlin" with your name. You could also opt to share the copyright with someone else and put e.g. an organization and your name in the copyright line.

OlegHahm · 2014-12-19T15:40:54Z

Rebase is required.

LudwigKnuepfer · 2015-01-10T14:27:16Z

@Troels51 ping - please squash and rebase.

LudwigKnuepfer · 2015-01-10T14:28:27Z

oh, and address #2052 (comment) as well, please (Word0 -> SAMD21_CPUID_WORD0 or whatever).

Troels51 · 2015-01-12T12:35:13Z

Rebased, and changed constant names

thomaseichinger · 2015-01-12T12:46:22Z

boards/samr21-xpro/Makefile.features

@@ -1 +1 @@
-FEATURES_PROVIDED += transceiver periph_gpio periph_spi cpp periph_timer periph_uart periph_i2c cpp periph_rtc
+FEATURES_PROVIDED += transceiver periph_gpio periph_spi cpp periph_timer periph_uart periph_i2c cpp periph_rtc periph_cpuid


Please add a newline.

Troels51 · 2015-01-12T12:51:14Z

Added newline and squashed

thomaseichinger · 2015-01-12T15:10:48Z

ACK & Go

Samr21: cpuid implementation

thomaseichinger added Platform: ARM Platform: This PR/issue effects ARM-based platforms Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation labels Nov 20, 2014

thomaseichinger added this to the Release 2014.12 milestone Nov 20, 2014

thomaseichinger self-assigned this Nov 20, 2014

thomaseichinger reviewed Nov 20, 2014
View reviewed changes

cpu/samd21/include/cpu-conf.h

/**

* @name CPUID_ID_LEN length of cpuid in bytes

* @{

*/

Copy link

Member

thomaseichinger Nov 20, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add a space here.

thomaseichinger mentioned this pull request Nov 20, 2014

board:cpu: RIOT port for the atsamr21xpro board #1646

Closed

21 tasks

Troels51 force-pushed the samr21-cpuid branch from 4bf4ebe to 207d4f1 Compare November 20, 2014 11:02

mehlis reviewed Nov 23, 2014
View reviewed changes

miri64 reviewed Dec 6, 2014
View reviewed changes

Troels51 force-pushed the samr21-cpuid branch from 1965ccb to 9fafc45 Compare December 15, 2014 14:20

Troels51 force-pushed the samr21-cpuid branch from 9fafc45 to 75b0f41 Compare December 15, 2014 14:28

miri64 reviewed Dec 15, 2014
View reviewed changes

cpu/samd21/periph/cpuid.c

@@ -0,0 +1,17 @@

Copy link

Member

miri64 Dec 15, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

License header missing.

Troels51 force-pushed the samr21-cpuid branch from 6c32739 to 799ced6 Compare December 19, 2014 15:51

OlegHahm modified the milestones: Release 2014.12, Release NEXT MAJOR Jan 6, 2015

Troels51 force-pushed the samr21-cpuid branch from 4b0ed9a to 165b718 Compare January 12, 2015 12:34

thomaseichinger reviewed Jan 12, 2015
View reviewed changes

thomaseichinger added the CI: needs squashing Commits in this PR need to be squashed; If set, CI systems will mark this PR as unmergable label Jan 12, 2015

samr21: cpuid implemented by reading 128 bits from flash

29b0e73

Troels51 force-pushed the samr21-cpuid branch from b3b6b35 to 29b0e73 Compare January 12, 2015 12:50

thomaseichinger removed the CI: needs squashing Commits in this PR need to be squashed; If set, CI systems will mark this PR as unmergable label Jan 12, 2015

thomaseichinger added a commit that referenced this pull request Jan 12, 2015

Merge pull request #2052 from Troels51/samr21-cpuid

61f3060

Samr21: cpuid implementation

thomaseichinger merged commit 61f3060 into RIOT-OS:master Jan 12, 2015

OlegHahm modified the milestone: Release 2015.12 Dec 18, 2015

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Samr21: cpuid implementation #2052

Samr21: cpuid implementation #2052

Troels51 commented Nov 20, 2014

thomaseichinger Nov 20, 2014

thomaseichinger commented Nov 20, 2014

Troels51 commented Nov 20, 2014

thomaseichinger commented Nov 20, 2014

mehlis Nov 23, 2014

miri64 Dec 15, 2014

LudwigKnuepfer Jan 11, 2015

thomaseichinger commented Nov 25, 2014

miri64 Dec 6, 2014

thomaseichinger commented Dec 8, 2014

Troels51 commented Dec 15, 2014

miri64 commented Dec 15, 2014

miri64 commented Dec 15, 2014

Troels51 commented Dec 15, 2014

miri64 Dec 15, 2014

N8Fear commented Dec 17, 2014

OlegHahm commented Dec 19, 2014

LudwigKnuepfer commented Jan 10, 2015

LudwigKnuepfer commented Jan 10, 2015

Troels51 commented Jan 12, 2015

thomaseichinger Jan 12, 2015

Troels51 commented Jan 12, 2015

thomaseichinger commented Jan 12, 2015

		@@ -1 +1 @@
		FEATURES_PROVIDED += transceiver periph_gpio periph_spi cpp periph_timer periph_uart periph_i2c cpp periph_rtc
		FEATURES_PROVIDED += transceiver periph_gpio periph_spi cpp periph_timer periph_uart periph_i2c cpp periph_rtc periph_cpuid

Samr21: cpuid implementation #2052

Samr21: cpuid implementation #2052

Conversation

Troels51 commented Nov 20, 2014

thomaseichinger Nov 20, 2014

Choose a reason for hiding this comment

thomaseichinger commented Nov 20, 2014

Troels51 commented Nov 20, 2014

thomaseichinger commented Nov 20, 2014

mehlis Nov 23, 2014

Choose a reason for hiding this comment

miri64 Dec 15, 2014

Choose a reason for hiding this comment

LudwigKnuepfer Jan 11, 2015

Choose a reason for hiding this comment

thomaseichinger commented Nov 25, 2014

miri64 Dec 6, 2014

Choose a reason for hiding this comment

thomaseichinger commented Dec 8, 2014

Troels51 commented Dec 15, 2014

miri64 commented Dec 15, 2014

miri64 commented Dec 15, 2014

Troels51 commented Dec 15, 2014

miri64 Dec 15, 2014

Choose a reason for hiding this comment

N8Fear commented Dec 17, 2014

OlegHahm commented Dec 19, 2014

LudwigKnuepfer commented Jan 10, 2015

LudwigKnuepfer commented Jan 10, 2015

Troels51 commented Jan 12, 2015

thomaseichinger Jan 12, 2015

Choose a reason for hiding this comment

Troels51 commented Jan 12, 2015

thomaseichinger commented Jan 12, 2015