core/panic: make reboot on panic configurable #20630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Area: core
benpicco
added
the
CI: ready for build
fabian18
approved these changes
Apr 26, 2024
maribu
approved these changes
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
Currently a
core_panic()will reboot the system withDEVELHELP=0and print a crash trace and lock up the system withDEVELHELP=1.There can be situations where this is not what's wanted, e.g. we might want to make a crash that only happens with
DEVELHELP=0more visible or we want to run withDEVELHELP=1and still auto reboot on a crash because we want to debug something unrelated.So add a config variable to toggle the behavior - the current configuration is kept as the default.
Testing procedure
The system should now auto-restart with
DEVELHELP=1andCFLAGS += -DCONFIG_CORE_REBOOT_ON_PANIC=1Issues/PRs references