Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drivers/at86rf2xx: fix tx prepare leading to inconsistent idle state #7275

Merged
merged 1 commit into from
Jun 29, 2017

Conversation

aabadie
Copy link
Contributor

@aabadie aabadie commented Jun 29, 2017

Fixes #7268

I compared changes introduced in #7115 with the previous master and to me the tx prepare function was resulting a different idle state. Which is certainly the cause of the communication not working.

Tested and now re-work with M3 and SAMR21 on IoT-LAB.

@aabadie aabadie added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) Area: network Area: Networking labels Jun 29, 2017
@aabadie aabadie added this to the Release 2017.07 milestone Jun 29, 2017
@aabadie aabadie added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Jun 29, 2017
@miri64
Copy link
Member

miri64 commented Jun 29, 2017

Confirmed, that #7268 is fixed. Now testing for #5486.

@miri64
Copy link
Member

miri64 commented Jun 29, 2017

Nope, #5486 is still an issue.

Copy link
Member

@miri64 miri64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes what it is supposed to, so ACK and go (hope OpenThread is still working with this)

@miri64 miri64 merged commit adc02a9 into RIOT-OS:master Jun 29, 2017
@aabadie
Copy link
Contributor Author

aabadie commented Jun 29, 2017

hope OpenThread is still working with this

Normally it should but #7149 might not work anymore. Anyway, I couldn't make it work this morning on IoT-LAB (several reasons involved)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: network Area: Networking CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants