at86rf2xx: Fix wrong state transition when leaving sleep state #8195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SLEEP is 0xf, the bitwise OR of (AT86RF2XX_STATE_RX_AACK_ON | AT86RF2XX_STATE_TX_ARET_ON) equals 0x1f, so this state transition to PLL_ON was wrongly triggered when leaving sleep for any mode which has 0x1X as its state code. The symptom is a hang in the transceiver driver thread because the transceiver is not listening to state transition commands while in sleep mode.
jnohlgard
added
Type: bug
|
already fixed in #8186? |
|
I guess so, doh |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SLEEP is 0xf, the bitwise OR of
(AT86RF2XX_STATE_RX_AACK_ON | AT86RF2XX_STATE_TX_ARET_ON) equals 0x1f,
so this state transition to PLL_ON was wrongly triggered when leaving
sleep for any mode which has 0x1X as its state code. The symptom is a
hang in the transceiver driver thread because the transceiver is not
listening to state transition commands while in sleep mode.
I hit this bug when using ifconfig to set some options while the transceiver was sleeping.