Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkg/micro-ecc: Update FEATURE_PERIPH_HWRNG -> MODULE_PERIPH_HWRNG #8227

Merged
merged 2 commits into from
Jan 17, 2018
Merged

pkg/micro-ecc: Update FEATURE_PERIPH_HWRNG -> MODULE_PERIPH_HWRNG #8227

merged 2 commits into from
Jan 17, 2018

Conversation

jnohlgard
Copy link
Member

The test application was successfully run on Mulle.

@jnohlgard jnohlgard added Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation Area: pkg Area: External package ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Dec 8, 2017
@jnohlgard jnohlgard added this to the Release 2018.01 milestone Dec 8, 2017
PeterKietzmann
PeterKietzmann approved these changes Dec 13, 2017
View reviewed changes
Copy link
Member

@PeterKietzmann PeterKietzmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK from my side but your commit messages are too long

@jnohlgard
Copy link
Member Author

will reword

@jnohlgard
Copy link
Member Author

done

@PeterKietzmann
Copy link
Member

Build still fails for mips boards. Might be related to this comment. Let's see what @neiljay says. I don't even know if there platforms provide a hwrng.

@cladmi
Copy link
Contributor

cladmi commented Dec 18, 2017

Do you know when the FEATURE_PERIPH_ have been deprecated or if there is an issue on this ?
It would be nice to have the reference in the commit message.

I think this was also the last lines using ifdef FEATURE_, so I think this can also be removed:

RIOT/makefiles/modules.inc.mk

Line 1 in d69291c

ED = $(addprefix FEATURE_,$(sort $(filter $(FEATURES_PROVIDED), $(FEATURES_REQUIRED))))

I will look into the MIPS PR.

@cladmi cladmi mentioned this pull request Dec 19, 2017
Closed
@cladmi cladmi added the State: waiting for other PR State: The PR requires another PR to be merged first label Dec 19, 2017
@cladmi
Copy link
Contributor

cladmi commented Dec 19, 2017

Waiting for PR: #8248

@cladmi cladmi mentioned this pull request Dec 19, 2017
Merged
kaspar030
kaspar030 approved these changes Dec 21, 2017
View reviewed changes
Copy link
Contributor

@kaspar030 kaspar030 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK.

@smlng
Copy link
Member

smlng commented Jan 12, 2018

murdock isn't happy, some undef reference, can you fix for the release 2018.01? Otherwise we need to postpone.

@neiljay
Copy link
Contributor

neiljay commented Jan 12, 2018

Waiting for PR: #8248

I'm waiting for @cladmi to ACK this one, then I'll create another which fixes this issue.

@cladmi
Copy link
Contributor

cladmi commented Jan 12, 2018 •
edited
Loading

I'm waiting for @cladmi to ACK this one, then I'll create another which fixes this issue.

Done, needs second ACK now.

@cladmi cladmi added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed State: waiting for other PR State: The PR requires another PR to be merged first CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Jan 12, 2018
@smlng
Copy link
Member

smlng commented Jan 12, 2018

even with #8248 merged the compile error persists.

@neiljay
Copy link
Contributor

neiljay commented Jan 15, 2018

@sming #8242 is not the fix (it did have the fix in for a while, but we decided to separate it into another PR), another PR is coming with the fix, hopefully today.

@neiljay
Copy link
Contributor

neiljay commented Jan 15, 2018

@smlng I have pushed what should be the fix as #8360

This was referenced Jan 15, 2018
Closed
Merged
@cladmi
Copy link
Contributor

cladmi commented Jan 15, 2018

The mentioned fix makes murdock build correctly.

@smlng
Copy link
Member

smlng commented Jan 15, 2018

@cladmi thanks for testing and reporting, then lets see that #8360 gets merged 😄

@smlng smlng added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Jan 15, 2018
smlng
smlng approved these changes Jan 17, 2018
View reviewed changes
Copy link
Member

@smlng smlng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well then lets do this! ACK and GO

@smlng smlng merged commit ba7cbd0 into RIOT-OS:master Jan 17, 2018
cladmi added a commit to cladmi/RIOT that referenced this pull request Jan 18, 2018
@cladmi
makefiles/modules.inc.mk: remove deprecated FEATURE_PERIPH_ macros
e554a19 
`#ifdef FEATURE_PERIPH_NAME` usage should now be replaced by
`#ifdef MODULE_PERIPH_NAME`.

This deprecation was started by pull requests RIOT-OS#8226 and RIOT-OS#8227.
@cladmi
Copy link
Contributor

cladmi commented Jan 22, 2018 •
edited
Loading

#8292 can now be merged as FEATURE_PERIPH_ are not used anymore.

@jnohlgard jnohlgard deleted the pr/micro-ecc-feature-periph branch February 14, 2018 07:09
panail pushed a commit to panail/RIOT that referenced this pull request Oct 29, 2018
@cladmi
makefiles/modules.inc.mk: remove deprecated FEATURE_PERIPH_ macros
07e5a47 
`#ifdef FEATURE_PERIPH_NAME` usage should now be replaced by
`#ifdef MODULE_PERIPH_NAME`.

This deprecation was started by pull requests RIOT-OS#8226 and RIOT-OS#8227.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaspar030 kaspar030 kaspar030 approved these changes

@PeterKietzmann PeterKietzmann PeterKietzmann approved these changes

@smlng smlng smlng approved these changes

@wentaoshang wentaoshang Awaiting requested review from wentaoshang

Assignees

@cgundogan cgundogan

Labels
Area: pkg Area: External package ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation
Projects
None yet
Milestone
Release 2018.01
Development

Successfully merging this pull request may close these issues.
7 participants
@jnohlgard @PeterKietzmann @cladmi @smlng @neiljay @kaspar030 @cgundogan