Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate concat changes to insert copies for nonpacked axes #2969

Draft
wants to merge 7 commits into
base: develop
Choose a base branch
from

Conversation

kahmed10
Copy link
Collaborator

Currently, we only eliminate concat if the axis = 0 or the axis > 0 but the data is packed (i.e., all dims up to axis = 1). This PR changes it so that copies are inserted.

@kahmed10 kahmed10 requested a review from pfultz2 April 12, 2024 15:51
@migraphx-bot
Copy link
Collaborator

Test Batch Rate new
d995fe
Rate old
070c2e
Diff Compare
torchvision-resnet50 64 2,824.56 2,826.14 -0.06%
torchvision-resnet50_fp16 64 6,558.41 6,576.83 -0.28%
torchvision-densenet121 32 2,094.51 2,090.60 0.19%
torchvision-densenet121_fp16 32 3,696.12 3,686.13 0.27%
torchvision-inceptionv3 32 1,604.19 1,605.47 -0.08%
torchvision-inceptionv3_fp16 32 2,555.28 2,555.50 -0.01%
cadene-inceptionv4 16 716.78 717.75 -0.14%
cadene-resnext64x4 16 680.82 680.72 0.01%
slim-mobilenet 64 5,865.53 5,908.97 -0.74%
slim-nasnetalarge 64 153.59 153.88 -0.19%
slim-resnet50v2 64 2,589.69 2,586.75 0.11%
bert-mrpc-onnx 8 919.95 960.21 -4.19% 🔴
bert-mrpc-tf 1 438.58 401.32 9.28% 🔆
pytorch-examples-wlang-gru 1 419.92 415.54 1.05%
pytorch-examples-wlang-lstm 1 381.86 384.72 -0.74%
torchvision-resnet50_1 1 603.45 604.26 -0.13%
cadene-dpn92_1 1 392.45 394.64 -0.55%
cadene-resnext101_1 1 333.10 326.95 1.88%
onnx-taau-downsample 1 306.39 307.13 -0.24%
dlrm-criteoterabyte 1 28.80 28.79 0.02%
dlrm-criteoterabyte_fp16 1 48.46 48.21 0.53%
agentmodel 1 7,423.52 7,621.72 -2.60%
unet_fp16 2 57.70 57.79 -0.17%
resnet50v1_fp16 1 884.00 895.00 -1.23%
resnet50v1_int8 1 828.81 826.04 0.34%
bert_base_cased_fp16 64 1,053.37 1,053.69 -0.03%
bert_large_uncased_fp16 32 300.75 301.61 -0.28%
bert_large_fp16 1 159.07 158.93 0.09%
distilgpt2_fp16 16 1,858.36 1,857.93 0.02%
yolov5s 1 466.78 474.32 -1.59%
tinyllama 1 33.01 32.96 0.16%
vicuna-fastchat 1 158.58 157.50 0.68%
whisper-tiny-encoder 1 348.21 347.91 0.09%
whisper-tiny-decoder 1 401.73 396.59 1.30%

This build is not recommended to merge 🔴

@migraphx-bot
Copy link
Collaborator


     ✅ bert-mrpc-onnx: PASSED: MIGraphX meets tolerance

     ✅ bert-mrpc-tf: PASSED: MIGraphX meets tolerance

     ✅ pytorch-examples-wlang-gru: PASSED: MIGraphX meets tolerance

     ✅ pytorch-examples-wlang-lstm: PASSED: MIGraphX meets tolerance

     ✅ torchvision-resnet50_1: PASSED: MIGraphX meets tolerance

     ✅ cadene-dpn92_1: PASSED: MIGraphX meets tolerance

     ✅ cadene-resnext101_1: PASSED: MIGraphX meets tolerance

     ✅ dlrm-criteoterabyte: PASSED: MIGraphX meets tolerance

     ✅ agentmodel: PASSED: MIGraphX meets tolerance

     ✅ unet: PASSED: MIGraphX meets tolerance

     ✅ resnet50v1: PASSED: MIGraphX meets tolerance

     ✅ bert_base_cased_fp16: PASSED: MIGraphX meets tolerance

🔴bert_large_uncased_fp16: FAILED: MIGraphX is not within tolerance - check verbose output


     ✅ bert_large: PASSED: MIGraphX meets tolerance

     ✅ yolov5s: PASSED: MIGraphX meets tolerance

     ✅ tinyllama: PASSED: MIGraphX meets tolerance

     ✅ vicuna-fastchat: PASSED: MIGraphX meets tolerance

     ✅ whisper-tiny-encoder: PASSED: MIGraphX meets tolerance

     ✅ whisper-tiny-decoder: PASSED: MIGraphX meets tolerance

     ✅ distilgpt2_fp16: PASSED: MIGraphX meets tolerance

Copy link

codecov bot commented Apr 16, 2024

Codecov Report

Attention: Patch coverage is 94.73684% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 91.85%. Comparing base (c3c0980) to head (ba8e9a4).
Report is 1 commits behind head on develop.

Files Patch % Lines
src/eliminate_concat.cpp 94.11% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2969   +/-   ##
========================================
  Coverage    91.85%   91.85%           
========================================
  Files          483      483           
  Lines        18580    18602   +22     
========================================
+ Hits         17066    17087   +21     
- Misses        1514     1515    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants